[FOP-2314] Caching xmlParserClassName in org.apache.fop.svg.SimpleSVGUserAgent

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: 2.5
• Fix Version/s: 2.2
• Component/s: renderer/svg
• Labels: performance
• Environment: Tested on Mac OSX 10.9, Java SE 7 (1.7.0_04)
• Assignee: Unassigned
• Reporter: Gonzalo Vasquez
• Created: 15/Nov/13 15:49
• Updated: 11/Apr/17 11:10
• Resolved: 24/Nov/13 11:42

Description

After having profiled an application I'm coding, and having detected hotspot methods, I've come across with a few suggestions por performance improvement which actually have worked in my environment.

Changing the referenced method to the following code makes the small trick:

From:
public String getXMLParserClassName() {
try

{ SAXParserFactory factory = SAXParserFactory.newInstance(); return factory.newSAXParser().getXMLReader().getClass().getName(); }

catch (Exception e)

{ return null; }

}

To:

private static final String xmlParserClassName;

static {
String result;
try

{ SAXParserFactory factory = SAXParserFactory.newInstance(); result = factory.newSAXParser().getXMLReader().getClass().getName(); }

catch (Exception e)

{ result = null; }

xmlParserClassName = result;
}

public String getXMLParserClassName()

{ return xmlParserClassName; }

Could this be added as a patch to the trunk please?