Fop
  1. Fop
  2. FOP-2055

fonts loaded twice (redundantly)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: font/unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • External issue ID:
      53143

      Description

      due to a coding error introduced in revision 1198853 [1], fonts are redundantly loaded twice

      [1] http://svn.apache.org/viewvc?view=revision&revision=1198853

      more specifically, the code change at [2]

      [2] http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontFileFinder.java?r1=1198853&r2=1198852&pathrev=1198853

      namely

      public List<URL> find(String dir) throws IOException {
      List<URL> results = new java.util.ArrayList<URL>();
      super.walk(new File(dir), results);
      + File directory = new File(dir);
      + if (!directory.isDirectory())

      { + eventListener.fontDirectoryNotFound(this, dir); + }

      else

      { + super.walk(directory, results); + }

      return results;
      }

      results in calling super.walk(...) twice which has the effect of adding each font twice to the returned List<URL>, which in turn results in each font being loaded twice in FontInfoConfigurator.addDirectories():

      fontURLList = fontFileFinder.find(directory);
      fontAdder.add(fontURLList, fontInfoList);

        Activity

        Glenn Adams created issue -

          People

          • Assignee:
            fop-dev
            Reporter:
            Glenn Adams
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development