Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
      None
    • Environment:
      Operating System: Linux
      Platform: PC
    • External issue ID:
      51928

      Description

      This is the eagerly anticipated upgrade of FOPs JUnit tests to JUnit4. There are a few notable differences:
      1) Tests can now be parameterized (I'll discuss this later).
      2) The test outputs have less meaningful names when parameterized, the layout engine tests used to be instantiated with the names of set as the name of the FO used in the test. Because these have been changed to be parameterized tests, the output is less useful. I haven't found a suitable way of changing the name of the test for a parameterized test short of overriding the org.junit.runners.Parameterized.

      I've tried to touch as little as possible with the layout engine tests, in terms of their reliance on the system properties being injected in. I wish to change that in a future commit, but I think it's a logically separate issue and I will create a separate patch for that.

      The layout engine tests do need a little TLC, there seems to be a fair amount of code duplication in that area. I'll address these at the same time as the patch above.

        Attachments

        1. junit4.patch
          186 kB
          Mehdi Houshmand
        2. junit4.patch
          193 kB
          Mehdi Houshmand

          Activity

            People

            • Assignee:
              fop-dev@xmlgraphics.apache.org fop-dev
              Reporter:
              med1985@gmail.com Mehdi Houshmand
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: