Uploaded image for project: 'FOP'
  1. FOP
  2. FOP-1891

[PATCH] Synchronize access to java.awt.color.ICC_Profile

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Resolution: Fixed
    • 2.5
    • None
    • unqualified
    • None
    • Operating System: All
      Platform: All
    • 50698

    Description

      In response to a recent post on fop-users@ (see: http://marc.info/?l=fop-user&m=129646673801270&w=2), the attached patch:

      • adds two methods to fop.util.ColorProfileUtil that perform calls to ICC_Profile.getInstance() in a synchronized fashion (only the InputStream and int variants are used)
      • replaces all direct calls to ICC_Profile.getInstance() in FOP's code with calls to one of those new methods

      Note: The issue mentioned in the original post is not addressed by this patch, as that instance of the issue arises somewhere in XMLGraphics.

      Probably a good step to take towards solving this in XG, is to migrate the ColorProfileUtil class there, and have FOP reference that one.

      Attachments

        1. synch_ICC_Profile.diff
          6 kB
          Andreas L. Delmelle

        Issue Links

          Activity

            People

              fop-dev@xmlgraphics.apache.org fop-dev
              adelmelle@apache.org Andreas L. Delmelle
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: