Fop
  1. Fop
  2. FOP-1870

[PATCH] Add support for different flow-name of fo:region-body in FOP

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: layout/unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • External issue ID:
      50391

      Description

      This patch is not an implementation of flow-maps. The intention is for simple-page-masters that reference flows that are not defined in the page-sequence should generate empty flows- that is pages with the content layed out in the region-body.
      This implementation is not inconsistent with section 6.4.1.5 of the XSL recommendation (1.0 & 1.1)

      example.fo (attached) will cause the trunk to throw due to unmapped flows, however this patch will produce an even and odd alternatives of empty and 'main flow' pages.

      This patch also introduces 3 dependencies as part of the unit test coverage:
      mockito-core-1.8.5.jar
      hamcrest.core-1.1.0.jar
      objenesis-1.0.0.jar
      They are to be placed in lib/build.

      1. unmapped_flow.patch
        62 kB
        Peter Hancock
      2. example.fo
        2 kB
        Peter Hancock

        Activity

        Hide
        Peter Hancock added a comment -

        Attachment unmapped_flow.patch has been added with description: Patch for enhancement

        Show
        Peter Hancock added a comment - Attachment unmapped_flow.patch has been added with description: Patch for enhancement
        Hide
        Peter Hancock added a comment -

        Attachment example.fo has been added with description: example .fo demonstrating patch

        Show
        Peter Hancock added a comment - Attachment example.fo has been added with description: example .fo demonstrating patch
        Hide
        Peter Hancock added a comment -

        All dependencies can be obtained from http://mockito.org/.
        mockito-1.8.5.zip has a directory called seperate-jars containing
        mockito-core-1.8.5.jar
        hamcrest.core-1.1.0.jar
        objenesis-1.0.0.jar

        Show
        Peter Hancock added a comment - All dependencies can be obtained from http://mockito.org/ . mockito-1.8.5.zip has a directory called seperate-jars containing mockito-core-1.8.5.jar hamcrest.core-1.1.0.jar objenesis-1.0.0.jar
        Hide
        Chris Bowditch added a comment -

        Hi Peter,

        Thanks for submitting this patch. I have reviewed it and found a couple of issues. There were some minor conflicts due to the age of the patch that I resolved. I also had to update the tests to Junit4. My question is around the AllTests class added to the pagination package. 2 test were added to this package:

        PageSequenceMasterTestCase
        RepeatablePageMasterAlternativesTestCase

        but the AllTest class only references PageSequenceMasterTestCase. Is that intentional or should it also reference the RepeatablePageMasterAlternativesTestCase?

        Thanks,

        Chris

        Show
        Chris Bowditch added a comment - Hi Peter, Thanks for submitting this patch. I have reviewed it and found a couple of issues. There were some minor conflicts due to the age of the patch that I resolved. I also had to update the tests to Junit4. My question is around the AllTests class added to the pagination package. 2 test were added to this package: PageSequenceMasterTestCase RepeatablePageMasterAlternativesTestCase but the AllTest class only references PageSequenceMasterTestCase. Is that intentional or should it also reference the RepeatablePageMasterAlternativesTestCase? Thanks, Chris
        Hide
        Peter Hancock added a comment -

        Well spotted Chris, RepeatablePageMasterAlternativesTestCase should be run.

        The AllTest class should contain something like

        @SuiteClasses(

        { PageSequenceMasterTestCase.class, RepeatablePageMasterAlternativesTestCase.class }

        )

        Show
        Peter Hancock added a comment - Well spotted Chris, RepeatablePageMasterAlternativesTestCase should be run. The AllTest class should contain something like @SuiteClasses( { PageSequenceMasterTestCase.class, RepeatablePageMasterAlternativesTestCase.class } )
        Hide
        Chris Bowditch added a comment -

        Thanks Peter. I've committed you patch and unit tests in revision 1229622

        Show
        Chris Bowditch added a comment - Thanks Peter. I've committed you patch and unit tests in revision 1229622

          People

          • Assignee:
            fop-dev
            Reporter:
            Peter Hancock
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development