Uploaded image for project: 'FOP'
  1. FOP
  2. FOP-1828

[PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

    Details

    • Type: Improvement
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • External issue ID:
      49695

      Description

      Replace several variable constants with appropriate constants from xmlgraphics UnitConv and GraphicsConstants.

      Searched on 25.4, 2.54, and 72 (for both UnitConv and GraphicsConstants)

      Questions regarding additional constants:

      1) UnitConv vs. org.apache.fop.fo.properties.FixedLength
      FixedLength contains redundant constants. Fix?

      2) Variable 72000 is used in multiple places in conjunction with variable 300. Fix?

      3) PCL uses var 300 many times; no constant set to represent as default.
      Fix?

        Attachments

        1. mypatch.diff
          21 kB
          Joshua Marquart

          Activity

            People

            • Assignee:
              fop-dev@xmlgraphics.apache.org fop-dev
              Reporter:
              joshdm Joshua Marquart
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: