Fop
  1. Fop
  2. FOP-1567

[PATCH] break-before not respected on blocks nested in inlines

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: page-master/layout
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • External issue ID:
      45715

      Description

      see attachment: should produce 5 pages, but results in only 3

      1. fop-45715-test.patch
        2 kB
        Luis Bernardo
      2. fop-45715.patch
        1.0 kB
        Luis Bernardo
      3. page-break-table-after-rev-1334058.pdf
        5 kB
        Matthias Reischenbacher
      4. page-break-table-before-rev-1334058.pdf
        6 kB
        Matthias Reischenbacher
      5. page-break-table.fo
        0.7 kB
        Matthias Reischenbacher
      6. testcase-fixed.pdf
        7 kB
        Luis Bernardo
      7. page_break.patch
        18 kB
        Luis Bernardo
      8. newtestcase.pdf
        7 kB
        Luis Bernardo
      9. testcase.pdf
        6 kB
        Luis Bernardo
      10. newtestcase.fo
        1 kB
        Luis Bernardo
      11. testcase.fo
        1 kB
        Andreas L. Delmelle

        Activity

        Hide
        Vincent Hennebert added a comment -

        Patch submitted in rev. 1380726:
        http://svn.apache.org/viewvc?rev=1380726&view=rev

        Thanks!
        Vincent

        Show
        Vincent Hennebert added a comment - Patch submitted in rev. 1380726: http://svn.apache.org/viewvc?rev=1380726&view=rev Thanks! Vincent
        Hide
        Luis Bernardo added a comment -

        layout engine test for attachment 29191 (patch)

        Show
        Luis Bernardo added a comment - layout engine test for attachment 29191 (patch)
        Hide
        Luis Bernardo added a comment -

        Attachment fop-45715-test.patch has been added with description: layout engine test

        Show
        Luis Bernardo added a comment - Attachment fop-45715-test.patch has been added with description: layout engine test
        Hide
        Luis Bernardo added a comment -

        it is surprising that the issue with the break-before in the table was not caught by this layout engine render-test: table_table-row_break-before.xml

        Show
        Luis Bernardo added a comment - it is surprising that the issue with the break-before in the table was not caught by this layout engine render-test: table_table-row_break-before.xml
        Hide
        Luis Bernardo added a comment -

        elements with a break-before need to have the associated LayoutManager implement and have the type of BreakOpportunity; TableLayoutManager was not in that situation and hence the problem. there may be other cases but the fix is simple. I will provide a layout test later.

        Show
        Luis Bernardo added a comment - elements with a break-before need to have the associated LayoutManager implement and have the type of BreakOpportunity; TableLayoutManager was not in that situation and hence the problem. there may be other cases but the fix is simple. I will provide a layout test later.
        Hide
        Luis Bernardo added a comment -

        Attachment fop-45715.patch has been added with description: fix for the break-before in a table

        Show
        Luis Bernardo added a comment - Attachment fop-45715.patch has been added with description: fix for the break-before in a table
        Hide
        Matthias Reischenbacher added a comment -

        Attachment page-break-table-after-rev-1334058.pdf has been added with description: PDF output after rev 1334058

        Show
        Matthias Reischenbacher added a comment - Attachment page-break-table-after-rev-1334058.pdf has been added with description: PDF output after rev 1334058
        Hide
        Matthias Reischenbacher added a comment -

        Attachment page-break-table-before-rev-1334058.pdf has been added with description: PDF output before rev 1334058

        Show
        Matthias Reischenbacher added a comment - Attachment page-break-table-before-rev-1334058.pdf has been added with description: PDF output before rev 1334058
        Hide
        Matthias Reischenbacher added a comment -

        Attachment page-break-table.fo has been added with description: testcase

        Show
        Matthias Reischenbacher added a comment - Attachment page-break-table.fo has been added with description: testcase
        Hide
        Matthias Reischenbacher added a comment -

        This patch breaks support of break-before property on fo:table elements. See also newly attached test case.

        Show
        Matthias Reischenbacher added a comment - This patch breaks support of break-before property on fo:table elements. See also newly attached test case.
        Hide
        Glenn Adams added a comment -

        please verify and close if satisfied with fix

        Show
        Glenn Adams added a comment - please verify and close if satisfied with fix
        Hide
        Glenn Adams added a comment -

        patch applied at http://svn.apache.org/viewvc?rev=1334058&view=rev

        thanks andreas and luis!

        Show
        Glenn Adams added a comment - patch applied at http://svn.apache.org/viewvc?rev=1334058&view=rev thanks andreas and luis!
        Hide
        Luis Bernardo added a comment -

        Attachment testcase-fixed.pdf has been added with description: new output with 5 pages.

        Show
        Luis Bernardo added a comment - Attachment testcase-fixed.pdf has been added with description: new output with 5 pages.
        Hide
        Luis Bernardo added a comment -

        Attachment page_break.patch has been added with description: patch to address original issue described

        Show
        Luis Bernardo added a comment - Attachment page_break.patch has been added with description: patch to address original issue described
        Hide
        Luis Bernardo added a comment -

        This patch fixes the original issue reported. The fix is not perfect and will probably need to be revisited in the future but it does its job without apparent side effects. With this fix break-before="page" in blocks inside inline elements (including nested inlines) are respected.

        This patch does not address the related issue exemplified by the newtescase.fo where the inline was replaced by a block. I will create a new ticket to log that issue.

        Show
        Luis Bernardo added a comment - This patch fixes the original issue reported. The fix is not perfect and will probably need to be revisited in the future but it does its job without apparent side effects. With this fix break-before="page" in blocks inside inline elements (including nested inlines) are respected. This patch does not address the related issue exemplified by the newtescase.fo where the inline was replaced by a block. I will create a new ticket to log that issue.
        Hide
        Luis Bernardo added a comment -

        Attachment newtestcase.pdf has been added with description: output of newtestcase.fo

        Show
        Luis Bernardo added a comment - Attachment newtestcase.pdf has been added with description: output of newtestcase.fo
        Hide
        Luis Bernardo added a comment -

        Attachment testcase.pdf has been added with description: output of original testcase.fo

        Show
        Luis Bernardo added a comment - Attachment testcase.pdf has been added with description: output of original testcase.fo
        Hide
        Luis Bernardo added a comment -

        Attachment newtestcase.fo has been added with description: related issue if inline replaced by block

        Show
        Luis Bernardo added a comment - Attachment newtestcase.fo has been added with description: related issue if inline replaced by block
        Hide
        Luis Bernardo added a comment -

        I think that if the inline is replaced by a block we should still get 5 pages but we get 6.

        Show
        Luis Bernardo added a comment - I think that if the inline is replaced by a block we should still get 5 pages but we get 6.
        Hide
        Glenn Adams added a comment -

        resetting P2 open bugs to P3 pending further review

        Show
        Glenn Adams added a comment - resetting P2 open bugs to P3 pending further review
        Hide
        Andreas L. Delmelle added a comment -

        Attachment testcase.fo has been added with description: testcase demonstrating the issue

        Show
        Andreas L. Delmelle added a comment - Attachment testcase.fo has been added with description: testcase demonstrating the issue

          People

          • Assignee:
            fop-dev
            Reporter:
            Andreas L. Delmelle
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development