Fop
  1. Fop
  2. FOP-1482

XMLWhiteSpaceHandler leaks memory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: layout/unqualified
    • Labels:
      None
    • Environment:
      Operating System: Linux
      Platform: All
    • External issue ID:
      44286

      Description

      org.apache.fop.fo.XMLWhiteSpaceHandler does not remove certain blocks from it's
      nestedBlockStack.

      1. XMLWhiteSpaceHandler.java.patch
        10 kB
        Stefan Ziel
      2. xaa.fo
        78 kB
        Stefan Ziel

        Activity

        Hide
        Stefan Ziel added a comment -

        Attachment xaa.fo has been added with description: fo - file which leaves approx 20 blocks on the stack for each page-sequence

        Show
        Stefan Ziel added a comment - Attachment xaa.fo has been added with description: fo - file which leaves approx 20 blocks on the stack for each page-sequence
        Hide
        Stefan Ziel added a comment -

        Attachment XMLWhiteSpaceHandler.java.patch has been added with description: patch to correct problem

        Show
        Stefan Ziel added a comment - Attachment XMLWhiteSpaceHandler.java.patch has been added with description: patch to correct problem
        Hide
        Andreas L. Delmelle added a comment -

        Yep, you're right. Seems to an oversight of mine... :/

        Thanks for spotting this! I'll apply it ASAP.

        Show
        Andreas L. Delmelle added a comment - Yep, you're right. Seems to an oversight of mine... :/ Thanks for spotting this! I'll apply it ASAP.
        Hide
        Andreas L. Delmelle added a comment -

        Hi Stefan,

        Just had a closer look at your patch. The fix itself definitely looks good (using parameters instead of
        member references to avoid the leak), but the applied re-styling of the code is less appreciated.
        Nothing big. I'm just referring to the tab-characters and some swallowed linefeeds... Would you mind
        terribly redoing the changes on a fresh checkout of the trunk, but avoid the code from being styled by
        whatever IDE you're using? That would be much appreciated!

        Again: thanks for the vigilance, and keep them coming.

        Show
        Andreas L. Delmelle added a comment - Hi Stefan, Just had a closer look at your patch. The fix itself definitely looks good (using parameters instead of member references to avoid the leak), but the applied re-styling of the code is less appreciated. Nothing big. I'm just referring to the tab-characters and some swallowed linefeeds... Would you mind terribly redoing the changes on a fresh checkout of the trunk, but avoid the code from being styled by whatever IDE you're using? That would be much appreciated! Again: thanks for the vigilance, and keep them coming.
        Hide
        Andreas L. Delmelle added a comment -

        OK, I guess you did mind.
        No harm done, since it was only one file.
        Modifications in the patch applied to the trunk.

        see: http://svn.apache.org/viewvc?rev=615598&view=rev

        Please take the remark about code-styling into account for any future patches (especially if they start
        involving changes to multiple source files...)

        Thanks for the input!

        Show
        Andreas L. Delmelle added a comment - OK, I guess you did mind. No harm done, since it was only one file. Modifications in the patch applied to the trunk. see: http://svn.apache.org/viewvc?rev=615598&view=rev Please take the remark about code-styling into account for any future patches (especially if they start involving changes to multiple source files...) Thanks for the input!
        Hide
        Glenn Adams added a comment -

        batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

        Show
        Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

          People

          • Assignee:
            fop-dev
            Reporter:
            Stefan Ziel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development