Fop
  1. Fop
  2. FOP-1430

[PATCH] No page-number-citation in FOEventHandler

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 0.94
    • Fix Version/s: None
    • Component/s: fo/unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: Other
    • External issue ID:
      43605

      Description

      There is no support for page-number-citation and page-number-citation-last in
      FOEventHandler. This is because of the following relatively simple omissions:

      (1) org.apache.fop.fo.FOEventHandler :
      o needs empty method startPageNumberCitation(PageNumberCitation)
      o needs empty method endPageNumberCitation(PageNumberCitation)
      o needs empty method startPageNumberCitationLast(PageNumberCitationLast)
      o needs empty method endPageNumberCitationLast(PageNumberCitationLast)
      (2) org.apache.fop.fo.flow.PageNumberCitation:
      o method startOfNode() needs to call
      getFOEventHandler().startPageNumberCitation(this);
      o method endOfNode() needs to call
      getFOEventHandler().endPageNumberCitation(this);
      (3) org.apache.fop.fo.flow.PageNumberCitationLast:
      o method startOfNode() needs to call
      getFOEventHandler().startPageNumberCitationLast(this);
      o method endOfNode() needs to call
      getFOEventHandler().endPageNumberCitationLast(this);

      The fixes are trivial (simply add about 15 missing lines as directed above).

        Issue Links

          Activity

          Hide
          V Schappert added a comment -

          This patch should completely resolve the bug – it is relatively
          straightforward.

          Show
          V Schappert added a comment - This patch should completely resolve the bug – it is relatively straightforward.
          Hide
          V Schappert added a comment -

          Attachment fop-43605-page-citation.patch has been added with description: Adds support for page-number-citation etc. to FOEventHandler...

          Show
          V Schappert added a comment - Attachment fop-43605-page-citation.patch has been added with description: Adds support for page-number-citation etc. to FOEventHandler...
          Hide
          Jeremias Maerki added a comment -

          Patch applied to FOP Trunk, thanks:
          http://svn.apache.org/viewvc?rev=596097&view=rev

          However, I had to modify the patch since it had a bug. See the commit message
          for details.

          Show
          Jeremias Maerki added a comment - Patch applied to FOP Trunk, thanks: http://svn.apache.org/viewvc?rev=596097&view=rev However, I had to modify the patch since it had a bug. See the commit message for details.
          Hide
          Glenn Adams added a comment -

          batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

          Show
          Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

            People

            • Assignee:
              fop-dev
              Reporter:
              V Schappert
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development