FOP
  1. FOP
  2. FOP-1400

[PATCH] AFP Renderer - output resolution control

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
      None
    • Environment:
      Operating System: other
      Platform: Other
    • External issue ID:
      43041

      Description

      • Introduced a a new configuration element
        <renderer-resolution>240</renderer-resolution> which is a child of <renderer
        mime="application/x-afp"> which allows you to configure the output resolution of
        the AFP renderer - I guess other renderers could follow this scheme if they wish
        to provide this feature.
      • For every class that was touched in the process of adding this new feature, I
        have done my best to fix any checkstyle problems (except for violations such as
        number of arguments in method > 7 etc). This should make it easier for the
        patch reviewer to check I have not introduced any additional checkstyle problems
        (only removed them).
      1. dpi_diff.txt
        180 kB
        Adrian Cumiskey
      2. dpi_diff.txt
        148 kB
        Adrian Cumiskey

        Activity

        Hide
        Adrian Cumiskey added a comment -

        Attachment dpi_diff.txt has been added with description: patch file

        Show
        Adrian Cumiskey added a comment - Attachment dpi_diff.txt has been added with description: patch file
        Hide
        Adrian Cumiskey added a comment -

        This patch supersedes the previous one. I discovered a subversion merge
        problem on AFPRenderer.java which is now fixed.

        Show
        Adrian Cumiskey added a comment - This patch supersedes the previous one. I discovered a subversion merge problem on AFPRenderer.java which is now fixed.
        Hide
        Adrian Cumiskey added a comment -

        Attachment dpi_diff.txt has been added with description: patch file

        Show
        Adrian Cumiskey added a comment - Attachment dpi_diff.txt has been added with description: patch file
        Hide
        Jeremias Maerki added a comment -

        I've got a question for those who use AFP: Adrian introduced a
        renderer-resolution setting. All the other renderers use target-resolution [1].
        Since the AFP renderer's default resolution is 240dpi instead of 72 dpi like for
        the other renderers. Switching to target-resolution would decrease the output
        quality for those who use the AFP renderer at its default settings. But
        introducing renderer-resolution adds a third resolution setting which could lead
        to confusion. Should we perhaps let each renderer try to give the user agent its
        default target resolution?

        Opinions? Ideas?

        [1] http://xmlgraphics.apache.org/fop/0.94/configuration.html#general-elements

        Show
        Jeremias Maerki added a comment - I've got a question for those who use AFP: Adrian introduced a renderer-resolution setting. All the other renderers use target-resolution [1] . Since the AFP renderer's default resolution is 240dpi instead of 72 dpi like for the other renderers. Switching to target-resolution would decrease the output quality for those who use the AFP renderer at its default settings. But introducing renderer-resolution adds a third resolution setting which could lead to confusion. Should we perhaps let each renderer try to give the user agent its default target resolution? Opinions? Ideas? [1] http://xmlgraphics.apache.org/fop/0.94/configuration.html#general-elements
        Hide
        Jeremias Maerki added a comment -

        Never mind my previous question. Looks like there was already a discussion:
        http://marc.info/?l=fop-dev&m=118597659210348&w=2

        Show
        Jeremias Maerki added a comment - Never mind my previous question. Looks like there was already a discussion: http://marc.info/?l=fop-dev&m=118597659210348&w=2
        Hide
        Jeremias Maerki added a comment -

        Patch applied with modification:
        Bugfix: SVGs were rendered in the wrong size when the target-resolution and the
        renderer-resolution differ.
        http://svn.apache.org/viewvc?rev=582131&view=rev

        Adrian, thanks for the patch! I know I once asked you to install Checkstyle and
        you took that to heart, but I'd be grateful if you wouldn't do too much
        Checkstyle cleanup as part of a patch. It makes it difficult to spot the actual
        modifications in all the differences.

        Show
        Jeremias Maerki added a comment - Patch applied with modification: Bugfix: SVGs were rendered in the wrong size when the target-resolution and the renderer-resolution differ. http://svn.apache.org/viewvc?rev=582131&view=rev Adrian, thanks for the patch! I know I once asked you to install Checkstyle and you took that to heart, but I'd be grateful if you wouldn't do too much Checkstyle cleanup as part of a patch. It makes it difficult to spot the actual modifications in all the differences.
        Hide
        Glenn Adams added a comment -

        batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

        Show
        Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

          People

          • Assignee:
            fop-dev
            Reporter:
            Adrian Cumiskey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development