[FOP-1244] [PATCH] Possible bug in PSTextRenderer

• Type: Bug
• Status: Closed
• Resolution: Won't Fix
• Affects Version/s: 2.5
• Component/s: renderer/ps
• Environment: Operating System: Linux; Platform: PC
• External issue ID: 40529
• Assignee: fop-dev
• Reporter: Peter Wainwright
• Created: 17/Sep/06 09:29
• Updated: 02/May/13 02:28
• Resolved: 01/Apr/12 13:50

Description

According to the comment, this class

• Renders the attributed character iterator of a <tt>TextNode</tt>.
• This class draws the text directly into the PSGraphics2D so that
• the text is not drawn using shapes which makes the PS files larger.
• If the text is simple enough to draw then it sets the font and calls
• drawString. If the text is complex or the cannot be translated
• into a simple drawString the StrokingTextPainter is used instead.

However,
The check for unsupported glyphs seems always to use the default font,
When makeFont is called the ACI should be initialized using aci.first(),
otherwise the position is undefined, the attributes (including font)
are therefore null, and the default font is used instead.

This bug seems to be masked in my case since the embedded SVG document I am
rendering has other unsupported attributes so the text has to be stroked
anyway. However, in the course of debugging I came across this and thought
I should mention it.

Could someone who understands this font handling see if this patch is
reasonable:

acro

Issue Links

• is depended upon by: FOP-1649 [PATCH] Full-featured TextPainter for PS output