Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
    • Environment:
      Operating System: other
      Platform: Other
    • External issue ID:
      38946

      Description

      Dear developers,

      I have created the first patch for proper color handling in fop. This patch
      replaces all occurences of other color methods with the java.awt.Color class.

      There are still some things left todo (such as removing PDFColor), but this
      patch is consistent and all

      1. color-ng-2.diff
        160 kB
        Max Berger
      2. color-ng.diff
        242 kB
        Max Berger

        Activity

        Max Berger created issue -
        Hide
        Max Berger added a comment -

        testcases work.

        Show
        Max Berger added a comment - testcases work.
        Hide
        Max Berger added a comment -

        Attachment color-ng.diff has been added with description: Patch for color handling

        Show
        Max Berger added a comment - Attachment color-ng.diff has been added with description: Patch for color handling
        Hide
        Max Berger added a comment -
        • removed some unnecessary reformatting in the original patch
        • added a TODO to another colorspace issue found
        • rewrote colorutil to use hashmap-based color lookup
        Show
        Max Berger added a comment - removed some unnecessary reformatting in the original patch added a TODO to another colorspace issue found rewrote colorutil to use hashmap-based color lookup
        Hide
        Max Berger added a comment -

        Attachment color-ng-2.diff has been added with description: Better version of the color patch

        Show
        Max Berger added a comment - Attachment color-ng-2.diff has been added with description: Better version of the color patch
        Hide
        Jeremias Maerki added a comment -

        Max, thank you very much for this patch. I think it is a very good step in the
        right direction. Your changes look very clean. Since this is a rather large work
        and contains new files, may I ask you to sign and submit an Individual
        Contributor License Agreement (ICLA) [1] (and a CCLA if necessary) to the Apache
        Software Foundation? This is just so everyone is on the safe side. Thank you!
        I'll integrate your patch as soon as the ASF's secretary records your ICLA.

        [1] http://www.apache.org/licenses/#clas

        Show
        Jeremias Maerki added a comment - Max, thank you very much for this patch. I think it is a very good step in the right direction. Your changes look very clean. Since this is a rather large work and contains new files, may I ask you to sign and submit an Individual Contributor License Agreement (ICLA) [1] (and a CCLA if necessary) to the Apache Software Foundation? This is just so everyone is on the safe side. Thank you! I'll integrate your patch as soon as the ASF's secretary records your ICLA. [1] http://www.apache.org/licenses/#clas
        Hide
        Jeremias Maerki added a comment -

        Max Berger's ICLA has finally been recorded. I'll go after this patch ASAP.

        Show
        Jeremias Maerki added a comment - Max Berger's ICLA has finally been recorded. I'll go after this patch ASAP.
        Hide
        Jeremias Maerki added a comment -

        Patch applied. Thanks a lot. The additional changes to the patch due to the
        changes since patch submission were no problem.
        http://svn.apache.org/viewcvs.cgi?rev=399185&view=rev

        Show
        Jeremias Maerki added a comment - Patch applied. Thanks a lot. The additional changes to the patch due to the changes since patch submission were no problem. http://svn.apache.org/viewcvs.cgi?rev=399185&view=rev
        Hide
        Glenn Adams added a comment -

        batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

        Show
        Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

          People

          • Assignee:
            fop-dev
            Reporter:
            Max Berger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development