Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-3157

Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseManager private API

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.0
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #314 (See https://builds.apache.org/job/Flume-trunk-hbase-1/314/)
        FLUME-3157. Refactor TestHDFSEventSinkOnMiniCluster to not use (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=32c167dccd711f163221b374bf6a4af68e66f0df)

        • (edit) flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #314 (See https://builds.apache.org/job/Flume-trunk-hbase-1/314/ ) FLUME-3157 . Refactor TestHDFSEventSinkOnMiniCluster to not use (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=32c167dccd711f163221b374bf6a4af68e66f0df ) (edit) flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java
        Hide
        denes Denes Arvay added a comment -

        Thanks Ferenc Szabo, I have committed this.

        Show
        denes Denes Arvay added a comment - Thanks Ferenc Szabo , I have committed this.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/flume/pull/164

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flume/pull/164
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 32c167dccd711f163221b374bf6a4af68e66f0df in flume's branch refs/heads/trunk from Ferenc Szabo
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=32c167d ]

        FLUME-3157. Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseManager private API

        This fix removes LeaseManager private API usages from tests in
        TestHDFSEventSinkOnMiniCluster as these methods are expected to be
        removed/changed in future versions of Hadoop/HDFS.

        Test refactored, it has the same result and behaviour.

        This closes #164

        Reviewers: Denes Arvay

        (Ferenc Szabo via Denes Arvay)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 32c167dccd711f163221b374bf6a4af68e66f0df in flume's branch refs/heads/trunk from Ferenc Szabo [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=32c167d ] FLUME-3157 . Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseManager private API This fix removes LeaseManager private API usages from tests in TestHDFSEventSinkOnMiniCluster as these methods are expected to be removed/changed in future versions of Hadoop/HDFS. Test refactored, it has the same result and behaviour. This closes #164 Reviewers: Denes Arvay (Ferenc Szabo via Denes Arvay)
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user szaboferee opened a pull request:

        https://github.com/apache/flume/pull/164

        FLUME-3157 Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseMa…

        …nager private API

        test refactored, it has the same result and behaviour

        Test ran successfully after the refactor

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/szaboferee/flume FLUME-3157

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/flume/pull/164.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #164


        commit 15429fb4b3c8b86d6874ca535326c55253bae7cc
        Author: Ferenc Szabo <fszabo@cloudera.com>
        Date: 2017-09-01T17:10:27Z

        FLUME-3157 Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseManager private API

        test refactored, it has the same result and behaviour


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user szaboferee opened a pull request: https://github.com/apache/flume/pull/164 FLUME-3157 Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseMa… …nager private API test refactored, it has the same result and behaviour Test ran successfully after the refactor You can merge this pull request into a Git repository by running: $ git pull https://github.com/szaboferee/flume FLUME-3157 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flume/pull/164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #164 commit 15429fb4b3c8b86d6874ca535326c55253bae7cc Author: Ferenc Szabo <fszabo@cloudera.com> Date: 2017-09-01T17:10:27Z FLUME-3157 Refactor TestHDFSEventSinkOnMiniCluster to not use LeaseManager private API test refactored, it has the same result and behaviour

          People

          • Assignee:
            fszabo Ferenc Szabo
            Reporter:
            fszabo Ferenc Szabo
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development