Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-3152

Add Flume Metric for Backup Checkpoint Errors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.0
    • Fix Version/s: 1.8.0
    • Component/s: File Channel
    • Labels:
      None

      Description

      File channel metrics should contain a counter for checkpoint backup errors

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #308 (See https://builds.apache.org/job/Flume-trunk-hbase-1/308/)
          FLUME-3152 Add Flume Metric for Backup Checkpoint Errors (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=4d79aa003aa02e8d513a1ae1406795d758143397)

          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounter.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounterMBean.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java
          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelErrorMetrics.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java
          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java
          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpoint.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV2.java
          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #308 (See https://builds.apache.org/job/Flume-trunk-hbase-1/308/ ) FLUME-3152 Add Flume Metric for Backup Checkpoint Errors (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=4d79aa003aa02e8d513a1ae1406795d758143397 ) (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounter.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounterMBean.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelErrorMetrics.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpoint.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV2.java (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flume/pull/156

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flume/pull/156
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4d79aa003aa02e8d513a1ae1406795d758143397 in flume's branch refs/heads/trunk from Ferenc Szabo
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=4d79aa0 ]

          FLUME-3152 Add Flume Metric for Backup Checkpoint Errors

          This change adds a new metric (channel.file.checkpoint.backup.write.error)
          to the File Channel. It gets incremented if an exception happens
          during backup checkpoints writes.

          This closes #156

          Reviewers: Denes Arvay

          (Ferenc Szabo via Denes Arvay)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4d79aa003aa02e8d513a1ae1406795d758143397 in flume's branch refs/heads/trunk from Ferenc Szabo [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=4d79aa0 ] FLUME-3152 Add Flume Metric for Backup Checkpoint Errors This change adds a new metric (channel.file.checkpoint.backup.write.error) to the File Channel. It gets incremented if an exception happens during backup checkpoints writes. This closes #156 Reviewers: Denes Arvay (Ferenc Szabo via Denes Arvay)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user szaboferee opened a pull request:

          https://github.com/apache/flume/pull/156

          FLUME-3152 Add Flume Metric for Backup Checkpoint Errors

          Added a new metric to the file channel

          new test case added
          build with tests was successful

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/szaboferee/flume FLUME-3152

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flume/pull/156.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #156


          commit 9187cd7bbe158a46db424366e4ebcf43d679e253
          Author: Ferenc Szabo <fszabo@cloudera.com>
          Date: 2017-08-21T12:29:38Z

          FLUME-3152 Add Flume Metric for Backup Checkpoint Errors

          Change-Id: I525e4be2d0f95f50e4fa2307fc225a4faaab5aec


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user szaboferee opened a pull request: https://github.com/apache/flume/pull/156 FLUME-3152 Add Flume Metric for Backup Checkpoint Errors Added a new metric to the file channel new test case added build with tests was successful You can merge this pull request into a Git repository by running: $ git pull https://github.com/szaboferee/flume FLUME-3152 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flume/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit 9187cd7bbe158a46db424366e4ebcf43d679e253 Author: Ferenc Szabo <fszabo@cloudera.com> Date: 2017-08-21T12:29:38Z FLUME-3152 Add Flume Metric for Backup Checkpoint Errors Change-Id: I525e4be2d0f95f50e4fa2307fc225a4faaab5aec

            People

            • Assignee:
              fszabo Ferenc Szabo
              Reporter:
              fszabo Ferenc Szabo
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development