Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-3003

testSourceCounter in TestSyslogUdpSource is flaky

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.7.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Issue Links

        Activity

        Hide
        bessbd Bessenyei Balázs Donát added a comment -

        Denes Arvay: thank you for the patch!

        The change looks good to me. (It would be better if we didn't have to do the sleep(), but I found no easy way to do that.)

        I'll leave some time for other people to review it. If nobody has any improvement ideas, I'll commit this tomorrow.

        Show
        bessbd Bessenyei Balázs Donát added a comment - Denes Arvay : thank you for the patch! The change looks good to me. (It would be better if we didn't have to do the sleep(), but I found no easy way to do that.) I'll leave some time for other people to review it. If nobody has any improvement ideas, I'll commit this tomorrow.
        Hide
        bessbd Bessenyei Balázs Donát added a comment -

        I'm about to commit this

        Show
        bessbd Bessenyei Balázs Donát added a comment - I'm about to commit this
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 27c725802b16915acaa3ea05cdac0236972af1f0 in flume's branch refs/heads/trunk from Denes Arvay
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=27c7258 ]

        FLUME-3003. Fix flaky testSourceCounter in TestSyslogUdpSource

        The event processing in SyslogUDPSource is handled on a separate thread by Netty so message delivery, thus the sourceCounter's increment can be delayed resulting in a flaky test.

        This patch fixes that issue by adding more delay when necessary.

        Reviewers: Lior Zeno, Bessenyei Balázs Donát

        (Denes Arvay via Bessenyei Balázs Donát)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 27c725802b16915acaa3ea05cdac0236972af1f0 in flume's branch refs/heads/trunk from Denes Arvay [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=27c7258 ] FLUME-3003 . Fix flaky testSourceCounter in TestSyslogUdpSource The event processing in SyslogUDPSource is handled on a separate thread by Netty so message delivery, thus the sourceCounter's increment can be delayed resulting in a flaky test. This patch fixes that issue by adding more delay when necessary. Reviewers: Lior Zeno, Bessenyei Balázs Donát (Denes Arvay via Bessenyei Balázs Donát)
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Flume-trunk-hbase-1 #207 (See https://builds.apache.org/job/Flume-trunk-hbase-1/207/)
        FLUME-3003. Fix flaky testSourceCounter in TestSyslogUdpSource (bessbd: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=27c725802b16915acaa3ea05cdac0236972af1f0)

        • (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Flume-trunk-hbase-1 #207 (See https://builds.apache.org/job/Flume-trunk-hbase-1/207/ ) FLUME-3003 . Fix flaky testSourceCounter in TestSyslogUdpSource (bessbd: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=27c725802b16915acaa3ea05cdac0236972af1f0 ) (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
        Hide
        bessbd Bessenyei Balázs Donát added a comment -

        Denes Arvay: thank you for the patch!

        Show
        bessbd Bessenyei Balázs Donát added a comment - Denes Arvay : thank you for the patch!
        Hide
        bessbd Bessenyei Balázs Donát added a comment -

        Lior Zeno: thank you for the review!

        Show
        bessbd Bessenyei Balázs Donát added a comment - Lior Zeno : thank you for the review!

          People

          • Assignee:
            denes Denes Arvay
            Reporter:
            denes Denes Arvay
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development