Details
-
Type:
Test
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.6.0
-
Fix Version/s: 1.7.0
-
Component/s: Sinks+Sources
-
Labels:None
Issue Links
- links to
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
I'm about to commit this
Commit 27c725802b16915acaa3ea05cdac0236972af1f0 in flume's branch refs/heads/trunk from Denes Arvay
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=27c7258 ]
FLUME-3003. Fix flaky testSourceCounter in TestSyslogUdpSource
The event processing in SyslogUDPSource is handled on a separate thread by Netty so message delivery, thus the sourceCounter's increment can be delayed resulting in a flaky test.
This patch fixes that issue by adding more delay when necessary.
Reviewers: Lior Zeno, Bessenyei Balázs Donát
(Denes Arvay via Bessenyei Balázs Donát)
FAILURE: Integrated in Jenkins build Flume-trunk-hbase-1 #207 (See https://builds.apache.org/job/Flume-trunk-hbase-1/207/)
FLUME-3003. Fix flaky testSourceCounter in TestSyslogUdpSource (bessbd: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=27c725802b16915acaa3ea05cdac0236972af1f0)
- (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
Denes Arvay: thank you for the patch!
Lior Zeno: thank you for the review!
Denes Arvay: thank you for the patch!
The change looks good to me. (It would be better if we didn't have to do the sleep(), but I found no easy way to do that.)
I'll leave some time for other people to review it. If nobody has any improvement ideas, I'll commit this tomorrow.