Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2974

Some tests are broken in TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Changes in FLUME-2318 broke some tests that have empty files

        Issue Links

          Activity

          Hide
          bessbd Bessenyei Balázs Donát added a comment -

          I'm working on finding the tests that became broken and fixing them

          Show
          bessbd Bessenyei Balázs Donát added a comment - I'm working on finding the tests that became broken and fixing them
          Hide
          bessbd Bessenyei Balázs Donát added a comment -

          I have created a reviewboard request at https://reviews.apache.org/r/51200/diff/1#index_header
          Please, review and provide feedback

          Show
          bessbd Bessenyei Balázs Donát added a comment - I have created a reviewboard request at https://reviews.apache.org/r/51200/diff/1#index_header Please, review and provide feedback
          Hide
          mpercy Mike Percy added a comment -

          +1

          Show
          mpercy Mike Percy added a comment - +1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9eb92dab0d24813e9a3871f0c7038920797c0466 in flume's branch refs/heads/trunk from Bessenyei Balázs Donát
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9eb92da ]

          FLUME-2974. Fix some broken SpoolDirSource unit tests

          TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader were
          broken as part of commit b6dede8c108e0d8e3516767de31e3a847c69cfe0.
          This patch fixes them again.

          (Bessenyei Balázs Donát via Mike Percy)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9eb92dab0d24813e9a3871f0c7038920797c0466 in flume's branch refs/heads/trunk from Bessenyei Balázs Donát [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9eb92da ] FLUME-2974 . Fix some broken SpoolDirSource unit tests TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader were broken as part of commit b6dede8c108e0d8e3516767de31e3a847c69cfe0. This patch fixes them again. (Bessenyei Balázs Donát via Mike Percy)
          Hide
          mpercy Mike Percy added a comment -

          Pushed to trunk. Thanks for the patch, Donat!

          Show
          mpercy Mike Percy added a comment - Pushed to trunk. Thanks for the patch, Donat!
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #198 (See https://builds.apache.org/job/Flume-trunk-hbase-1/198/)
          FLUME-2974. Fix some broken SpoolDirSource unit tests (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9eb92dab0d24813e9a3871f0c7038920797c0466)

          • (edit) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java
          • (edit) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #198 (See https://builds.apache.org/job/Flume-trunk-hbase-1/198/ ) FLUME-2974 . Fix some broken SpoolDirSource unit tests (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9eb92dab0d24813e9a3871f0c7038920797c0466 ) (edit) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java (edit) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java

            People

            • Assignee:
              bessbd Bessenyei Balázs Donát
              Reporter:
              bessbd Bessenyei Balázs Donát
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development