[FLUME-2785] Add default non-zero threads value for Thrift source, to avoid OutofMemoryException

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.6.0
• Fix Version/s: notrack
• Component/s: Sinks+Sources
• Labels: patch

Environment

linux_64 2.6.32.57, Oracle JDK 1.7

• Release Note: Add default `threads` value for Thrift RPC source.
• Flags: Patch
• Assignee: Unassigned
• Reporter: Jackey Lyu
• Created: 06/Sep/15 07:26
• Updated: 11/Dec/15 09:07

Description

The current implementation of thrift source in `flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java`, there is something can be done to improve the usability of thrift source.

If users did not config the `threads` parameter for thrift source, the default threads number will be Integer.MAX_VALUE, which may easily cause OutofMemoryError if no threads are in idle status.

It's better to add a non-zero default value for it.

And in the manual https://flume.apache.org/FlumeUserGuide.html#thrift-source, the `threads` parameter is not required, I think it is better to notice that it is required.