Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2485

Thrift Source tests fail on Oracle JDK 8

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.7.0
    • Component/s: Sinks+Sources
    • Labels:

      Description

      Thrift Source tests fail on Oracle JDK 8:

      https://travis-ci.org/Stratio/flume/jobs/36817396#L6245

      testAppendBatch(org.apache.flume.source.TestThriftSource) Time elapsed: 6083 sec <<< FAILURE!
      java.lang.AssertionError
      at org.junit.Assert.fail(Assert.java:92)
      at org.junit.Assert.assertTrue(Assert.java:43)
      at org.junit.Assert.assertTrue(Assert.java:54)
      at org.apache.flume.source.TestThriftSource.testAppendBatch(TestThriftSource.java:144)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:483)
      at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
      at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
      at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
      at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
      at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
      at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
      at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
      at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
      at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
      at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
      at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
      at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
      at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
      at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
      at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
      at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:483)
      at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
      at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
      at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
      at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
      at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

        Activity

        Hide
        hshreedharan Hari Shreedharan added a comment -

        Work needs to be done to make the codebase compatible with JDK 8. Currently our build may not be JDK 8 compatible.

        Show
        hshreedharan Hari Shreedharan added a comment - Work needs to be done to make the codebase compatible with JDK 8. Currently our build may not be JDK 8 compatible.
        Hide
        myroch Miroslav Holubec added a comment -

        patch attached, seems to be caused by JDK8 optimizations

        Show
        myroch Miroslav Holubec added a comment - patch attached, seems to be caused by JDK8 optimizations
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Have you updated the pom.xml or just using the JDK8 for making the build. I am using JDK8 for building Flume and strangely it working for me.

        Show
        paliwalashish Ashish Paliwal added a comment - Have you updated the pom.xml or just using the JDK8 for making the build. I am using JDK8 for building Flume and strangely it working for me.
        Hide
        myroch Miroslav Holubec added a comment -

        it happens only sometimes, depends on processing speed

        Show
        myroch Miroslav Holubec added a comment - it happens only sometimes, depends on processing speed
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Ok, I ran into this issue on JDK 8. Can you please do following

        1. We follow patch naming convention as FLUME-JIRANUM-version.patch, Could you please rename as FLUME-2485-0.patch and upload again preferably rebasing the same.
        2. Open a review request for the same on http://reviews.apache.org/

        Show
        paliwalashish Ashish Paliwal added a comment - Ok, I ran into this issue on JDK 8. Can you please do following 1. We follow patch naming convention as FLUME-JIRANUM-version.patch, Could you please rename as FLUME-2485 -0.patch and upload again preferably rebasing the same. 2. Open a review request for the same on http://reviews.apache.org/
        Hide
        jrufus Johny Rufus added a comment -

        +1, Running into this issue a lot, since we have not heard back from Miroslav Holubec, am renaming/rebasing (if needed) the patch to our convention and committing this.

        Show
        jrufus Johny Rufus added a comment - +1, Running into this issue a lot, since we have not heard back from Miroslav Holubec , am renaming/rebasing (if needed) the patch to our convention and committing this.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. LGTM

        Show
        hshreedharan Hari Shreedharan added a comment - +1. LGTM
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Johny Rufus Feel free to commit

        Show
        hshreedharan Hari Shreedharan added a comment - Johny Rufus Feel free to commit
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5239b618c2caf4c6351048c758ad84f0c67aaf86 in flume's branch refs/heads/trunk from Johny Rufus
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=5239b61 ]

        FLUME-2485. Thrift Source tests fail on Oracle JDK 8

        (Miroslav Holubec via Johny Rufus)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5239b618c2caf4c6351048c758ad84f0c67aaf86 in flume's branch refs/heads/trunk from Johny Rufus [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=5239b61 ] FLUME-2485 . Thrift Source tests fail on Oracle JDK 8 (Miroslav Holubec via Johny Rufus)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c4460bdbf6147618d90871842d52c20a311a18b7 in flume's branch refs/heads/flume-1.7 from Johny Rufus
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=c4460bd ]

        FLUME-2485. Thrift Source tests fail on Oracle JDK 8

        (Miroslav Holubec via Johny Rufus)

        Show
        jira-bot ASF subversion and git services added a comment - Commit c4460bdbf6147618d90871842d52c20a311a18b7 in flume's branch refs/heads/flume-1.7 from Johny Rufus [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=c4460bd ] FLUME-2485 . Thrift Source tests fail on Oracle JDK 8 (Miroslav Holubec via Johny Rufus)
        Hide
        jrufus Johny Rufus added a comment -

        Committed. Thanks Miroslav Holubec !!

        Show
        jrufus Johny Rufus added a comment - Committed. Thanks Miroslav Holubec !!
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Flume-trunk-hbase-1 #117 (See https://builds.apache.org/job/Flume-trunk-hbase-1/117/)
        FLUME-2485. Thrift Source tests fail on Oracle JDK 8 (johnyrufus: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=5239b618c2caf4c6351048c758ad84f0c67aaf86)

        • flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Flume-trunk-hbase-1 #117 (See https://builds.apache.org/job/Flume-trunk-hbase-1/117/ ) FLUME-2485 . Thrift Source tests fail on Oracle JDK 8 (johnyrufus: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=5239b618c2caf4c6351048c758ad84f0c67aaf86 ) flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java

          People

          • Assignee:
            myr0ch@gmail.com Miroslav Holubec
            Reporter:
            smolav Santiago M. Mola
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development