Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2479

Kafka property auto.commit.enable is incorrect for KafkaSource

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      The KafkaSource uses auto.commit.enabled (the d should be removed)

      1. FLUME-2479.1.patch
        24 kB
        Gwen Shapira
      2. FLUME-2479.0.patch
        1 kB
        Gwen Shapira

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Flume-trunk-hbase-98 #26 (See https://builds.apache.org/job/Flume-trunk-hbase-98/26/)
          FLUME-2479. Kafka property auto.commit.enable is incorrect for KafkaSource. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e1cb6913f358e4de54d69d1f6f21edecf06a9da2)

          • flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceConstants.java
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceUtilTest.java
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceTest.java
            FLUME-2479. Adding new test files. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9b2c28d805b89b8b3eac8f082e580e313f44c384)
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSourceUtil.java
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #26 (See https://builds.apache.org/job/Flume-trunk-hbase-98/26/ ) FLUME-2479 . Kafka property auto.commit.enable is incorrect for KafkaSource. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e1cb6913f358e4de54d69d1f6f21edecf06a9da2 ) flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceConstants.java flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceUtilTest.java flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceTest.java FLUME-2479 . Adding new test files. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9b2c28d805b89b8b3eac8f082e580e313f44c384 ) flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSourceUtil.java flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in flume-trunk #666 (See https://builds.apache.org/job/flume-trunk/666/)
          FLUME-2479. Kafka property auto.commit.enable is incorrect for KafkaSource. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e1cb6913f358e4de54d69d1f6f21edecf06a9da2)

          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceUtilTest.java
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceTest.java
          • flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceConstants.java
            FLUME-2479. Adding new test files. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9b2c28d805b89b8b3eac8f082e580e313f44c384)
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSourceUtil.java
          • flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in flume-trunk #666 (See https://builds.apache.org/job/flume-trunk/666/ ) FLUME-2479 . Kafka property auto.commit.enable is incorrect for KafkaSource. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e1cb6913f358e4de54d69d1f6f21edecf06a9da2 ) flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceUtilTest.java flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceTest.java flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceConstants.java FLUME-2479 . Adding new test files. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9b2c28d805b89b8b3eac8f082e580e313f44c384 ) flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSourceUtil.java flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 29ca0bae3f1e85e74ae8371ed6b598b7fe794a3a in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=29ca0ba ]

          FLUME-2479. Adding new test files.

          (Gwen Shapira via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 29ca0bae3f1e85e74ae8371ed6b598b7fe794a3a in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=29ca0ba ] FLUME-2479 . Adding new test files. (Gwen Shapira via Hari)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9b2c28d805b89b8b3eac8f082e580e313f44c384 in flume's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9b2c28d ]

          FLUME-2479. Adding new test files.

          (Gwen Shapira via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9b2c28d805b89b8b3eac8f082e580e313f44c384 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9b2c28d ] FLUME-2479 . Adding new test files. (Gwen Shapira via Hari)
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Committed! Thanks Gwen!

          Show
          hshreedharan Hari Shreedharan added a comment - Committed! Thanks Gwen!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit be2dbf1ab68c8b22f565585a627886e78e190503 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=be2dbf1 ]

          FLUME-2479. Kafka property auto.commit.enable is incorrect for KafkaSource.

          (Gwen Shapira via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit be2dbf1ab68c8b22f565585a627886e78e190503 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=be2dbf1 ] FLUME-2479 . Kafka property auto.commit.enable is incorrect for KafkaSource. (Gwen Shapira via Hari)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e1cb6913f358e4de54d69d1f6f21edecf06a9da2 in flume's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=e1cb691 ]

          FLUME-2479. Kafka property auto.commit.enable is incorrect for KafkaSource.

          (Gwen Shapira via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit e1cb6913f358e4de54d69d1f6f21edecf06a9da2 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=e1cb691 ] FLUME-2479 . Kafka property auto.commit.enable is incorrect for KafkaSource. (Gwen Shapira via Hari)
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. Committing.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. Committing.
          Hide
          gwenshap Gwen Shapira added a comment -

          Fixed failing tests and renamed test classes.

          Show
          gwenshap Gwen Shapira added a comment - Fixed failing tests and renamed test classes.
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Looks like the tests were not running because the name was not the same as the include pattern. When I changed the include pattern, tests fail:

          testKafkaConsumerProperties(org.apache.flume.source.kafka.KafkaSourceUtilTest) Time elapsed: 13 sec <<< FAILURE!
          org.junit.ComparisonFailure: expected:<[false]> but was:<[override.default.autocommit]>

          Show
          hshreedharan Hari Shreedharan added a comment - Looks like the tests were not running because the name was not the same as the include pattern. When I changed the include pattern, tests fail: testKafkaConsumerProperties(org.apache.flume.source.kafka.KafkaSourceUtilTest) Time elapsed: 13 sec <<< FAILURE! org.junit.ComparisonFailure: expected:< [false] > but was:< [override.default.autocommit] >
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. Looks good. Running tests now.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. Looks good. Running tests now.
          Hide
          gwenshap Gwen Shapira added a comment -

          Fixed typos.

          Show
          gwenshap Gwen Shapira added a comment - Fixed typos.

            People

            • Assignee:
              gwenshap Gwen Shapira
              Reporter:
              hshreedharan Hari Shreedharan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development