[FLUME-2461] memoryChannel bytesRemaining counting error

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.5.0.1
• Component/s: Sinks+Sources
• Labels: patch reviewboard-missing unit-test-missing
• Assignee: Unassigned
• Reporter: Wei Yang
• Created: 12/Sep/14 01:42
• Updated: 01/Jun/22 19:01

Description

In doRollback function putByteCounter permits are released by bytesRemaining. This is wrong for the below cases:
In the doCommit function:
1)
if(!bytesRemaining.tryAcquire(putByteCounter, keepAlive,
TimeUnit.SECONDS))

{ throw new ChannelException("Cannot commit transaction. Heap space " + "limit of " + byteCapacity + "reached. Please increase heap space" + " allocated to the channel as the sinks may not be keeping up " + "with the sources"); }

2)
if(!queueRemaining.tryAcquire(-remainingChange, keepAlive, TimeUnit.SECONDS))

{ bytesRemaining.release(putByteCounter); throw new ChannelFullException("Space for commit to queue couldn't be acquired." + " Sinks are likely not keeping up with sources, or the buffer size is too tight"); }

When they throw ChannelException, bytesRemaining should not release any permits.