Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2328

FileChannel Dual Checkpoint Backup Thread not released on Application stop

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: File Channel
    • Labels:
      None

      Description

      In my application wired the filechannel with dual checkpoint enabled. Even after calling application.stop() i can see checkpoint backup thread is still in waiting state.
      "[channel=c1] - CheckpointBackUpThread" prio=6 tid=0x3a069400 nid=0x8a4 waiting on condition [0x3b17f000]
      Since i am usign java service wrapper to run application and for stopping service i am waiting all user threads to be released, service is not stopping gracefully even after waiting for 5 mins.

      in code i can see checkpointBackUpExecutor is started
      if (shouldBackup) {
      checkpointBackUpExecutor = Executors.newSingleThreadExecutor( new ThreadFactoryBuilder().setNameFormat( getName() + " - CheckpointBackUpThread").build());
      } else

      { checkpointBackUpExecutor = null; }

      ....

      there is no shutdown call for checkpointBackUpExecutor in anywhere in EventQueueBackingStoreFile

      1. FLUME-2328.patch
        1 kB
        Hari Shreedharan

        Activity

        Hide
        hshreedharan Hari Shreedharan added a comment -

        This patch fixes this issue.

        Show
        hshreedharan Hari Shreedharan added a comment - This patch fixes this issue.
        Hide
        gopinathan.av Gopinathan A added a comment -

        Patch LGFM +1

        Show
        gopinathan.av Gopinathan A added a comment - Patch LGFM +1
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        +1

        Show
        jarcec Jarek Jarcec Cecho added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c9b531e70a655e331f18012d3c24614ac2c66b75 in flume's branch refs/heads/trunk from Jarek Jarcec Cecho
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=c9b531e ]

        FLUME-2328: FileChannel Dual Checkpoint Backup Thread not released on Application stop

        (Hari Shreedharan via Jarek Jarcec Cecho)

        Show
        jira-bot ASF subversion and git services added a comment - Commit c9b531e70a655e331f18012d3c24614ac2c66b75 in flume's branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=c9b531e ] FLUME-2328 : FileChannel Dual Checkpoint Backup Thread not released on Application stop (Hari Shreedharan via Jarek Jarcec Cecho)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6d3d0cd8e23026a63b6ce05f14ae92a251654903 in flume's branch refs/heads/flume-1.5 from Jarek Jarcec Cecho
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6d3d0cd ]

        FLUME-2328: FileChannel Dual Checkpoint Backup Thread not released on Application stop

        (Hari Shreedharan via Jarek Jarcec Cecho)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6d3d0cd8e23026a63b6ce05f14ae92a251654903 in flume's branch refs/heads/flume-1.5 from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6d3d0cd ] FLUME-2328 : FileChannel Dual Checkpoint Backup Thread not released on Application stop (Hari Shreedharan via Jarek Jarcec Cecho)
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you for your contribution Hari Shreedharan!

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you for your contribution Hari Shreedharan !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #554 (See https://builds.apache.org/job/flume-trunk/554/)
        FLUME-2328: FileChannel Dual Checkpoint Backup Thread not released on Application stop (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=c9b531e70a655e331f18012d3c24614ac2c66b75)

        • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #554 (See https://builds.apache.org/job/flume-trunk/554/ ) FLUME-2328 : FileChannel Dual Checkpoint Backup Thread not released on Application stop (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=c9b531e70a655e331f18012d3c24614ac2c66b75 ) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java

          People

          • Assignee:
            hshreedharan Hari Shreedharan
            Reporter:
            arajput Arun
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development