Flume
  1. Flume
  2. FLUME-2305

BucketWriter#close must cancel idleFuture

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      We use a ScheduledExecutorService to close the files after a time period. If the task has been submitted, the service does not cancel that task by default. In the ScheduledThreadPoolExecutor class: this field "executeExistingDelayedTasksAfterShutdown" is set to true, by default - which causes the task to be executed even if the executor was shutdown.

      If we don't cancel it, the agent does not die till idleTimeout even though every other component is stopped.

      1. FLUME-2305.patch
        0.8 kB
        Hari Shreedharan

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6m 35s 1 Hari Shreedharan 28/Jan/14 23:19
          Patch Available Patch Available Resolved Resolved
          33m 42s 1 Jarek Jarcec Cecho 28/Jan/14 23:52
          Hari Shreedharan made changes -
          Link This issue is duplicated by FLUME-2306 [ FLUME-2306 ]
          Jarek Jarcec Cecho made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s v1.5.0 [ 12324642 ]
          Resolution Fixed [ 1 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 251478f2e937330d302abdcfd529ce0a6732b9af in branch refs/heads/flume-1.5 from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=251478f ]

          FLUME-2305. BucketWriter#close must cancel idleFuture

          (Hari Shreedharan via Jarek Jarcec Cecho)

          Show
          ASF subversion and git services added a comment - Commit 251478f2e937330d302abdcfd529ce0a6732b9af in branch refs/heads/flume-1.5 from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=251478f ] FLUME-2305 . BucketWriter#close must cancel idleFuture (Hari Shreedharan via Jarek Jarcec Cecho)
          Hide
          ASF subversion and git services added a comment -

          Commit 044ba300311a4a3e682a946bd0821c2b52acc190 in branch refs/heads/trunk from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=044ba30 ]

          FLUME-2305. BucketWriter#close must cancel idleFuture

          (Hari Shreedharan via Jarek Jarcec Cecho)

          Show
          ASF subversion and git services added a comment - Commit 044ba300311a4a3e682a946bd0821c2b52acc190 in branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=044ba30 ] FLUME-2305 . BucketWriter#close must cancel idleFuture (Hari Shreedharan via Jarek Jarcec Cecho)
          Hide
          Jarek Jarcec Cecho added a comment -

          +1

          Show
          Jarek Jarcec Cecho added a comment - +1
          Hari Shreedharan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hari Shreedharan made changes -
          Attachment FLUME-2305.patch [ 12625764 ]
          Hari Shreedharan made changes -
          Field Original Value New Value
          Environment We use a ScheduledExecutorService to close the files after a time period. If the task has been submitted, the service does not cancel that task by default. In the ScheduledThreadPoolExecutor class: this field "executeExistingDelayedTasksAfterShutdown" is set to true, by default - which causes the task to be executed even if the executor was shutdown.
          Description We use a ScheduledExecutorService to close the files after a time period. If the task has been submitted, the service does not cancel that task by default. In the ScheduledThreadPoolExecutor class: this field "executeExistingDelayedTasksAfterShutdown" is set to true, by default - which causes the task to be executed even if the executor was shutdown.

          If we don't cancel it, the agent does not die till idleTimeout even though every other component is stopped.
          Hari Shreedharan created issue -

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              Hari Shreedharan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development