Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      This version includes this commit, which speeds up the close method - that can improve replay speed:
      https://github.com/jankotek/MapDB/commit/70be94def92a137401716ea1611a6f11604b8c25

      1. FLUME-2292-0.patch
        1 kB
        Ashish Paliwal

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #537 (See https://builds.apache.org/job/flume-trunk/537/)
        FLUME-2292. Upgrade mapdb to 0.9.8 (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=bfd8e508a7498cd70a76e2269b610d063d30c270)

        • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java
        • pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #537 (See https://builds.apache.org/job/flume-trunk/537/ ) FLUME-2292 . Upgrade mapdb to 0.9.8 (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=bfd8e508a7498cd70a76e2269b610d063d30c270 ) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java pom.xml
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed, rev: bfd8e508a7498cd70a76e2269b610d063d30c270. Thanks Ashish!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed, rev: bfd8e508a7498cd70a76e2269b610d063d30c270. Thanks Ashish!
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Committing.

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Committing.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Looks like they made RandomAccessFile the default, so a replacement should not be necessary. There are test cases to test the functionality, so that should be fine.

        Show
        hshreedharan Hari Shreedharan added a comment - Looks like they made RandomAccessFile the default, so a replacement should not be necessary. There are test cases to test the functionality, so that should be fine.
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Hari Shreedharan The patch is ready. There are two change - pom update and one API (randomAccessFileEnableIfNeeded())has been deleted from DBMaker class. Couldn't find an API to use for replacement.

        Is there any test case that need to be added to validate the changes?

        Show
        paliwalashish Ashish Paliwal added a comment - Hari Shreedharan The patch is ready. There are two change - pom update and one API (randomAccessFileEnableIfNeeded())has been deleted from DBMaker class. Couldn't find an API to use for replacement. Is there any test case that need to be added to validate the changes?
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Please go ahead.

        Show
        hshreedharan Hari Shreedharan added a comment - Please go ahead.
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Hari Shreedharan This should be a Improvement JIRA, rather than Bug? Shall I take a stab at it?

        Show
        paliwalashish Ashish Paliwal added a comment - Hari Shreedharan This should be a Improvement JIRA, rather than Bug? Shall I take a stab at it?

          People

          • Assignee:
            paliwalashish Ashish Paliwal
            Reporter:
            hshreedharan Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development