Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2290

AbstractRpcSink does not properly shutdown the cxnResetExecutor executor and its tasks

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.4.0
    • None
    • None
    • None
    • Linux
      java version "1.6.0_38"
      Java(TM) SE Runtime Environment (build 1.6.0_38-b05)
      Java HotSpot(TM) 64-Bit Server VM (build 20.13-b02, mixed mode)

    Description

      in the AbstactRpcSink.stop() method, cxnResetExecutor.shutdown() is called, but this will not terminate scheduled tasks. you must explicitly cancel the task.

      however, i believe you guys tried to handle this because of the call to cxnResetExecutor.awaitTermination(), but mishandled the return code. if "false" is returned you want to call cxnResetExecutor.shutdownNow(), not if true is returned.

      my recommendation is to capture the ScheduledFuture returned and cancel the task explicitly after calling cxnResetExecutor.shutdown(). then if awaitTermination still doesn't work, call cxnResetExecutor.shutdownNow()

      Attachments

        Activity

          People

            Unassigned Unassigned
            btoddb B. Todd Burruss
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: