Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2252

Add null check before closing table in HbaseSink

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: v1.4.0
    • Fix Version/s: v1.5.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      26 Nov 2013 17:36:42,433 INFO  [conf-file-poller-0] (org.apache.flume.node.Application.stopAllComponents:115)  - Stopping Sink k1
      26 Nov 2013 17:36:42,433 INFO  [conf-file-poller-0] (org.apache.flume.lifecycle.LifecycleSupervisor.unsupervise:171)  - Stopping component: SinkRunner: { policy:org.apache.flume.sink.DefaultSinkProcessor@46edf730 counterGroup:{ name:null counters:{} } }
      26 Nov 2013 17:36:42,433 ERROR [conf-file-poller-0] (org.apache.flume.node.Application.stopAllComponents:118)  - Error while stopping SinkRunner: { policy:org.apache.flume.sink.DefaultSinkProcessor@46edf730 counterGroup:{ name:null counters:{} } }
      java.lang.NullPointerException
      	at org.apache.flume.sink.hbase.HBaseSink.stop(HBaseSink.java:169)
      	at org.apache.flume.sink.DefaultSinkProcessor.stop(DefaultSinkProcessor.java:53)
      	at org.apache.flume.SinkRunner.stop(SinkRunner.java:115)
      	at org.apache.flume.lifecycle.LifecycleSupervisor.unsupervise(LifecycleSupervisor.java:172)
      	at org.apache.flume.node.Application.stopAllComponents(Application.java:116)
      	at org.apache.flume.node.Application.handleConfigurationEvent(Application.java:87)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:69)
      	at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)
      	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:302)
      	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:285)
      	at com.google.common.eventbus.EventBus.post(EventBus.java:249)
      	at org.apache.flume.node.PollingPropertiesFileConfigurationProvider$FileWatcherRunnable.run(PollingPropertiesFileConfigurationProvider.java:140)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
      	at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
      

        Activity

        Hide
        gopinathan.av Gopinathan A added a comment -

        minor patch, so skipping RB

        Show
        gopinathan.av Gopinathan A added a comment - minor patch, so skipping RB
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1.

        Show
        hshreedharan Hari Shreedharan added a comment - +1.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 63d26c19adf250fdd4d3b98e2b049d2b5cefc698 in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=63d26c1 ]

        FLUME-2252. Add null check before closing table in HbaseSink

        (Gopinathan A via Hari Shreedharan)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 63d26c19adf250fdd4d3b98e2b049d2b5cefc698 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=63d26c1 ] FLUME-2252 . Add null check before closing table in HbaseSink (Gopinathan A via Hari Shreedharan)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 839e8e67fd75b2f2af9898b4b82f9570981e329c in flume's branch refs/heads/flume-1.5 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=839e8e6 ]

        FLUME-2252. Add null check before closing table in HbaseSink

        (Gopinathan A via Hari Shreedharan)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 839e8e67fd75b2f2af9898b4b82f9570981e329c in flume's branch refs/heads/flume-1.5 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=839e8e6 ] FLUME-2252 . Add null check before closing table in HbaseSink (Gopinathan A via Hari Shreedharan)
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed! Thanks Gopinathan!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed! Thanks Gopinathan!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #562 (See https://builds.apache.org/job/flume-trunk/562/)
        FLUME-2252. Add null check before closing table in HbaseSink (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=63d26c19adf250fdd4d3b98e2b049d2b5cefc698)

        • flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
        • flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #562 (See https://builds.apache.org/job/flume-trunk/562/ ) FLUME-2252 . Add null check before closing table in HbaseSink (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=63d26c19adf250fdd4d3b98e2b049d2b5cefc698 ) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java

          People

          • Assignee:
            gopinathan.av Gopinathan A
            Reporter:
            gopinathan.av Gopinathan A
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development