[FLUME-2243] AvroSource to use TransceiverThreadFactory for Thread naming while initializing NioServerSocketChannelFactory

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0
• Component/s: Sinks+Sources
• Assignee: Ashish Paliwal
• Reporter: Ashish Paliwal
• Created: 21/Nov/13 11:31
• Updated: 04/May/14 04:18
• Resolved: 11/Mar/14 20:07

Description

Currently in Avro source, we use
socketChannelFactory = new NioServerSocketChannelFactory
(Executors .newCachedThreadPool(), Executors.newCachedThreadPool());

This would create generic Thread names like pool-1-thread-1. It would be good to use a ThreadFactory, like we use in NettyAvroRpcClient for better identification of Threads in log file

ExecutorService bossExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
"Avro " + NettyTransceiver.class.getSimpleName() + " Boss"));
ExecutorService workerExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
"Avro " + NettyTransceiver.class.getSimpleName() + " I/O Worker"));

Move the TransceiverThreadFactory class to util package (from private static class) and update the usage in code.

Issue Links

• links to: Review Link