Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2243

AvroSource to use TransceiverThreadFactory for Thread naming while initializing NioServerSocketChannelFactory

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      Currently in Avro source, we use
      socketChannelFactory = new NioServerSocketChannelFactory
      (Executors .newCachedThreadPool(), Executors.newCachedThreadPool());

      This would create generic Thread names like pool-1-thread-1. It would be good to use a ThreadFactory, like we use in NettyAvroRpcClient for better identification of Threads in log file

      ExecutorService bossExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
      "Avro " + NettyTransceiver.class.getSimpleName() + " Boss"));
      ExecutorService workerExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
      "Avro " + NettyTransceiver.class.getSimpleName() + " I/O Worker"));

      Move the TransceiverThreadFactory class to util package (from private static class) and update the usage in code.

        Attachments

          Activity

            People

            • Assignee:
              paliwalashish Ashish Paliwal
              Reporter:
              paliwalashish Ashish Paliwal

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment