Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2235

idleFuture should be cancelled at the start of append

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      It seems like if idleTimeout is reached in the middle of an append call, it will rotate the file while a write is happening, since the idleFuture is not cancelled before the append starts.

      1. FLUME-2235.patch
        2 kB
        Hari Shreedharan
      2. FLUME-2235.patch
        1 kB
        Hari Shreedharan

        Activity

        Hide
        hshreedharan Hari Shreedharan added a comment -

        Updated patch that waits for idleFuture to complete upto timeout

        Show
        hshreedharan Hari Shreedharan added a comment - Updated patch that waits for idleFuture to complete upto timeout
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you for the patch Hari Shreedharan, it looks good to me - +1.

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you for the patch Hari Shreedharan , it looks good to me - +1.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Committed to trunk and flume-1.5.

        Show
        jarcec Jarek Jarcec Cecho added a comment - Committed to trunk and flume-1.5 .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in flume-trunk #522 (See https://builds.apache.org/job/flume-trunk/522/)
        FLUME-2235. idleFuture should be cancelled at the start of append (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=705abaf00fbf8ee69ac88cbccae47c1a33f4b4b2)

        • flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in flume-trunk #522 (See https://builds.apache.org/job/flume-trunk/522/ ) FLUME-2235 . idleFuture should be cancelled at the start of append (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=705abaf00fbf8ee69ac88cbccae47c1a33f4b4b2 ) flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java

          People

          • Assignee:
            hshreedharan Hari Shreedharan
            Reporter:
            hshreedharan Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development