Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2229

Backoff period gets reset too often in OrderSelector

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      In OrderSelector.java, the backoff period is calculated by using the number of sequential failures seen to the same host. Since CONSIDER_SEQUENTIAL_RANGE is set to 2 seconds, if the host is not selected for connection within 2 seconds of the backoff period ending, the sequential failures variable is reset and backoff period is not increased.

      We must increase the value of CONSIDER_SEQUENTIAL_RANGE so that the backoff is not reset too often.

      1. FLUME-2229.patch
        2 kB
        Hari Shreedharan

        Issue Links

          Activity

          Hide
          hshreedharan Hari Shreedharan added a comment -

          Trivial patch, skipping rb

          Show
          hshreedharan Hari Shreedharan added a comment - Trivial patch, skipping rb
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          +1

          Show
          jarcec Jarek Jarcec Cecho added a comment - +1
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          Committed to trunk and cherry-picked to flume-1.5. Thank you for your contribution Hari Shreedharan!

          Show
          jarcec Jarek Jarcec Cecho added a comment - Committed to trunk and cherry-picked to flume-1.5. Thank you for your contribution Hari Shreedharan !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in flume-trunk #520 (See https://builds.apache.org/job/flume-trunk/520/)
          FLUME-2229. Backoff period gets reset too often in OrderSelector (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a89897bec4e7d6f3342ed966c61668e8a8139af5)

          • flume-ng-sdk/src/main/java/org/apache/flume/util/OrderSelector.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in flume-trunk #520 (See https://builds.apache.org/job/flume-trunk/520/ ) FLUME-2229 . Backoff period gets reset too often in OrderSelector (jarcec: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a89897bec4e7d6f3342ed966c61668e8a8139af5 ) flume-ng-sdk/src/main/java/org/apache/flume/util/OrderSelector.java
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          The Jenkins failure do not seem to be relevant - the job is failing for some time already.

          Show
          jarcec Jarek Jarcec Cecho added a comment - The Jenkins failure do not seem to be relevant - the job is failing for some time already.
          Hide
          hshreedharan Hari Shreedharan added a comment -

          This was committed sometime back.

          Show
          hshreedharan Hari Shreedharan added a comment - This was committed sometime back.

            People

            • Assignee:
              hshreedharan Hari Shreedharan
              Reporter:
              hshreedharan Hari Shreedharan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development