Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2213

MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4.0
        • Fix Version/s: 1.4.1, 1.5.0
        • Component/s: Sinks+Sources
        • Labels:
          None

          Description

          Otherwise the each thread will have it's own registry which isn't great for getting a sense of the overall metrics, i.e. aggregated across all threads.

          1. Text File
            FLUME-2213-v3.patch
            5 kB
            wolfgang hoschek

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            whoschek wolfgang hoschek added a comment -

            better patch, now also shared registry among sinks that use the same morphlineFile and morphlineId

            Show
            whoschek wolfgang hoschek added a comment - better patch, now also shared registry among sinks that use the same morphlineFile and morphlineId
            Hide
            Permalink
            whoschek wolfgang hoschek added a comment -

            add some more metrics

            Show
            whoschek wolfgang hoschek added a comment - add some more metrics
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            +1. Looks good. Running tests and committing.

            Show
            hshreedharan Hari Shreedharan added a comment - +1. Looks good. Running tests and committing.
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            Committed, rev: c420fad. Thanks Wolfgang!

            Show
            hshreedharan Hari Shreedharan added a comment - Committed, rev: c420fad. Thanks Wolfgang!
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in flume-trunk #514 (See https://builds.apache.org/job/flume-trunk/514/)
            FLUME-2213. MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c420fad5d03dc8d17dce7fe3e59bf3b742f3d22d)

            • flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/MorphlineHandlerImpl.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #514 (See https://builds.apache.org/job/flume-trunk/514/ ) FLUME-2213 . MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c420fad5d03dc8d17dce7fe3e59bf3b742f3d22d ) flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/MorphlineHandlerImpl.java

              People

              • Assignee:
                whoschek wolfgang hoschek
                Reporter:
                whoschek wolfgang hoschek
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development