Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2213

MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.0
    • 1.4.1, 1.5.0
    • Sinks+Sources
    • None

    Description

      Otherwise the each thread will have it's own registry which isn't great for getting a sense of the overall metrics, i.e. aggregated across all threads.

      Attachments

        1. FLUME-2213-v3.patch
          5 kB
          Wolfgang Hoschek

        Activity

          better patch, now also shared registry among sinks that use the same morphlineFile and morphlineId

          whoschek Wolfgang Hoschek added a comment - better patch, now also shared registry among sinks that use the same morphlineFile and morphlineId

          add some more metrics

          whoschek Wolfgang Hoschek added a comment - add some more metrics

          +1. Looks good. Running tests and committing.

          hshreedharan Hari Shreedharan added a comment - +1. Looks good. Running tests and committing.

          Committed, rev: c420fad. Thanks Wolfgang!

          hshreedharan Hari Shreedharan added a comment - Committed, rev: c420fad. Thanks Wolfgang!
          hudson Hudson added a comment -

          SUCCESS: Integrated in flume-trunk #514 (See https://builds.apache.org/job/flume-trunk/514/)
          FLUME-2213. MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c420fad5d03dc8d17dce7fe3e59bf3b742f3d22d)

          • flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/MorphlineHandlerImpl.java
          hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #514 (See https://builds.apache.org/job/flume-trunk/514/ ) FLUME-2213 . MorphlineInterceptor should share metric registry across threads for better (aggregate) reporting (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c420fad5d03dc8d17dce7fe3e59bf3b742f3d22d ) flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/MorphlineHandlerImpl.java

          People

            whoschek Wolfgang Hoschek
            whoschek Wolfgang Hoschek
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: