Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2192

AbstractSinkProcessor stop incorrectly calls start

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: v1.4.0
    • Fix Version/s: v1.4.1, v1.5.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      AbstractSinkProcessor incorrectly calls start when trying to stop. Patch is attached.

      1. FLUME-2192.patch
        0.6 kB
        Jeremy Karlson

        Activity

        Hide
        hshreedharan Hari Shreedharan added a comment -

        Good catch. Looks like your patch has a line endings issue. See this patch for an idea of the format:
        https://issues.apache.org/jira/secure/attachment/12602646/FLUME-2188.patch

        Use git diff to generate the patch.

        Show
        hshreedharan Hari Shreedharan added a comment - Good catch. Looks like your patch has a line endings issue. See this patch for an idea of the format: https://issues.apache.org/jira/secure/attachment/12602646/FLUME-2188.patch Use git diff to generate the patch.
        Hide
        karlj000 Jeremy Karlson added a comment -

        Sorry about that, I had colour turned on. I think this one is better.

        Show
        karlj000 Jeremy Karlson added a comment - Sorry about that, I had colour turned on. I think this one is better.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Running tests and committing

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Running tests and committing
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed, rev: f017ce5. Thanks Jeremy!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed, rev: f017ce5. Thanks Jeremy!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #517 (See https://builds.apache.org/job/flume-trunk/517/)
        FLUME-2192. AbstractSinkProcessor stop incorrectly calls start (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=f017ce5aca00d280ad6ee94e63fe3b44c326c5cf)

        • flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkProcessor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #517 (See https://builds.apache.org/job/flume-trunk/517/ ) FLUME-2192 . AbstractSinkProcessor stop incorrectly calls start (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=f017ce5aca00d280ad6ee94e63fe3b44c326c5cf ) flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkProcessor.java

          People

          • Assignee:
            karlj000 Jeremy Karlson
            Reporter:
            karlj000 Jeremy Karlson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development