Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2175

Update Developer Guide with notes on how to upgrade Protocol Buffer version

    Details

    • Type: Documentation
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.8.0
    • Component/s: Docs
    • Labels:

      Issue Links

        Activity

        Hide
        roshan_naik Roshan Naik added a comment -

        Patch adds steps for upgrading Proto Buff version to Dev guide

        Show
        roshan_naik Roshan Naik added a comment - Patch adds steps for upgrading Proto Buff version to Dev guide
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Roshan Naik Can we create a RB for this and close the process. Seems a trivial one.

        Show
        paliwalashish Ashish Paliwal added a comment - Roshan Naik Can we create a RB for this and close the process. Seems a trivial one.
        Hide
        roshan_naik Roshan Naik added a comment -

        RB: https://reviews.apache.org/r/15956/

        Normally we dont bother with RB for trivial patches that are easy to review.. and post comments right here on the jira.

        Show
        roshan_naik Roshan Naik added a comment - RB: https://reviews.apache.org/r/15956/ Normally we dont bother with RB for trivial patches that are easy to review.. and post comments right here on the jira.
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Got it. Since the patch was stuck, hence asked. I am fine with JIRA comments, it just need to move.

        Show
        paliwalashish Ashish Paliwal added a comment - Got it. Since the patch was stuck, hence asked. I am fine with JIRA comments, it just need to move.
        Hide
        sati Attila Simon added a comment -

        Denes Arvay this looks good to me (followed the steps to regenerate java code) and the patch from RB also applies clearly. Seems like a quick and safe commit.

        Show
        sati Attila Simon added a comment - Denes Arvay this looks good to me (followed the steps to regenerate java code) and the patch from RB also applies clearly. Seems like a quick and safe commit.
        Hide
        denes Denes Arvay added a comment -

        Thanks Roshan Naik for the patch, Ashish Paliwal and Attila Simon for the review, I'm going to commit this.

        Show
        denes Denes Arvay added a comment - Thanks Roshan Naik for the patch, Ashish Paliwal and Attila Simon for the review, I'm going to commit this.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b54f085ffa89b74c9e91e478e864424bfbe0a7a2 in flume's branch refs/heads/trunk from Roshan Naik
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=b54f085 ]

        FLUME-2175. Document Protocol Buffer upgrade steps

        Update Developer Guide with notes on how to upgrade Protocol Buffer
        version.

        Reviewers: Ashish Paliwal, Attila Simon

        (Roshan Naik via Denes Arvay)

        Show
        jira-bot ASF subversion and git services added a comment - Commit b54f085ffa89b74c9e91e478e864424bfbe0a7a2 in flume's branch refs/heads/trunk from Roshan Naik [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=b54f085 ] FLUME-2175 . Document Protocol Buffer upgrade steps Update Developer Guide with notes on how to upgrade Protocol Buffer version. Reviewers: Ashish Paliwal, Attila Simon (Roshan Naik via Denes Arvay)
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #258 (See https://builds.apache.org/job/Flume-trunk-hbase-1/258/)
        FLUME-2175. Document Protocol Buffer upgrade steps (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=b54f085ffa89b74c9e91e478e864424bfbe0a7a2)

        • (edit) flume-ng-doc/sphinx/FlumeDeveloperGuide.rst
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #258 (See https://builds.apache.org/job/Flume-trunk-hbase-1/258/ ) FLUME-2175 . Document Protocol Buffer upgrade steps (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=b54f085ffa89b74c9e91e478e864424bfbe0a7a2 ) (edit) flume-ng-doc/sphinx/FlumeDeveloperGuide.rst

          People

          • Assignee:
            roshan_naik Roshan Naik
            Reporter:
            roshan_naik Roshan Naik
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development