Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2156

Unregister then re-register MonitoredCounterGroup JMX MBeans on reconfigure

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4.0
        • Fix Version/s: 1.5.0
        • Component/s: None
        • Labels:
          None

          Description

          When a soft restart (reconfiguration) happens, we should first unregister, then re-register the JMX MBean to avoid spurious error messages in the logs, and even breaking the metrics in some cases.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mpercy Mike Percy added a comment -

            Relatively small patch, skipping RB.

            Show
            mpercy Mike Percy added a comment - Relatively small patch, skipping RB.
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            +1. Running tests and committing.

            Show
            hshreedharan Hari Shreedharan added a comment - +1. Running tests and committing.
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            Committed, rev: 507ff137160021dda2c4a08199746228827c9432. Thanks Mike!

            Show
            hshreedharan Hari Shreedharan added a comment - Committed, rev: 507ff137160021dda2c4a08199746228827c9432. Thanks Mike!
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in flume-trunk #490 (See https://builds.apache.org/job/flume-trunk/490/)
            FLUME-2156. Unregister then re-register MonitoredCounterGroup JMX MBeans on reconfigure (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=507ff137160021dda2c4a08199746228827c9432)

            • flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java
            • flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #490 (See https://builds.apache.org/job/flume-trunk/490/ ) FLUME-2156 . Unregister then re-register MonitoredCounterGroup JMX MBeans on reconfigure (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=507ff137160021dda2c4a08199746228827c9432 ) flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java

              People

              • Assignee:
                mpercy Mike Percy
                Reporter:
                mpercy Mike Percy
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development