Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2151

Windows: Update TestExecSource to use native commands on Windows

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4.0
        • Fix Version/s: 1.5.0
        • Component/s: Windows
        • Labels:

          Description

          The test invokes unix commands like 'ps' etc.
          Need to use Windows alternatives.

            Issue Links

            links to

            Web Link Code Review

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              roshan_naik Roshan Naik added a comment -

              All tests have been updated to use windows commands on windows

              Show
              roshan_naik Roshan Naik added a comment - All tests have been updated to use windows commands on windows
              Hide
              Permalink
              roshan_naik Roshan Naik added a comment -

              revised patch

              Show
              roshan_naik Roshan Naik added a comment - revised patch
              Hide
              Permalink
              roshan_naik Roshan Naik added a comment -

              updating patch. one file was missing in the patch.

              Show
              roshan_naik Roshan Naik added a comment - updating patch. one file was missing in the patch.
              Hide
              Permalink
              roshan_naik Roshan Naik added a comment -

              rebased patch

              Show
              roshan_naik Roshan Naik added a comment - rebased patch
              Hide
              Permalink
              paliwalashish Ashish Paliwal added a comment -

              Roshan Naik Can you please open a review request for the patch?
              I applied the patch, and the it works on windows. Have access to a windows machine for time being.

              Show
              paliwalashish Ashish Paliwal added a comment - Roshan Naik Can you please open a review request for the patch? I applied the patch, and the it works on windows. Have access to a windows machine for time being.
              Hide
              Permalink
              roshan_naik Roshan Naik added a comment -

              Adding code review link

              Show
              roshan_naik Roshan Naik added a comment - Adding code review link
              Hide
              Permalink
              hshreedharan Hari Shreedharan added a comment -

              +1. Tested it on Mac and Linux. Works ok.

              Show
              hshreedharan Hari Shreedharan added a comment - +1. Tested it on Mac and Linux. Works ok.
              Hide
              Permalink
              jira-bot ASF subversion and git services added a comment -

              Commit 1f21df7e11f5fe8a3dcd0bd34116289c02943a64 in flume's branch refs/heads/trunk from Hari Shreedharan
              [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=1f21df7 ]

              FLUME-2151. Windows: Update TestExecSource to use native commands on Windows

              (Roshan Naik via Hari Shreedharan)

              Show
              jira-bot ASF subversion and git services added a comment - Commit 1f21df7e11f5fe8a3dcd0bd34116289c02943a64 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=1f21df7 ] FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (Roshan Naik via Hari Shreedharan)
              Hide
              Permalink
              jira-bot ASF subversion and git services added a comment -

              Commit 38d8377e912768e63fb518bbf6f65ede19b14618 in flume's branch refs/heads/flume-1.5 from Hari Shreedharan
              [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=38d8377 ]

              FLUME-2151. Windows: Update TestExecSource to use native commands on Windows

              (Roshan Naik via Hari Shreedharan)

              Show
              jira-bot ASF subversion and git services added a comment - Commit 38d8377e912768e63fb518bbf6f65ede19b14618 in flume's branch refs/heads/flume-1.5 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=38d8377 ] FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (Roshan Naik via Hari Shreedharan)
              Hide
              Permalink
              hshreedharan Hari Shreedharan added a comment -

              Committed! Thanks Roshan

              Show
              hshreedharan Hari Shreedharan added a comment - Committed! Thanks Roshan
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in flume-trunk #563 (See https://builds.apache.org/job/flume-trunk/563/)
              FLUME-2151. Windows: Update TestExecSource to use native commands on Windows (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=1f21df7e11f5fe8a3dcd0bd34116289c02943a64)

              • flume-ng-core/src/test/resources/test_command.ps1
              • flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #563 (See https://builds.apache.org/job/flume-trunk/563/ ) FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=1f21df7e11f5fe8a3dcd0bd34116289c02943a64 ) flume-ng-core/src/test/resources/test_command.ps1 flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java

                People

                • Assignee:
                  roshan_naik Roshan Naik
                  Reporter:
                  roshan_naik Roshan Naik
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development