Flume
  1. Flume
  2. FLUME-2151

Windows: Update TestExecSource to use native commands on Windows

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.4.0
    • Fix Version/s: v1.5.0
    • Component/s: Windows
    • Labels:

      Description

      The test invokes unix commands like 'ps' etc.
      Need to use Windows alternatives.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          12m 1 Roshan Naik 07/Aug/13 21:47
          Open Open Patch Available Patch Available
          19h 46m 2 Roshan Naik 07/Aug/13 23:57
          Patch Available Patch Available Resolved Resolved
          216d 19h 39m 1 Hari Shreedharan 12/Mar/14 19:36
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in flume-trunk #563 (See https://builds.apache.org/job/flume-trunk/563/)
          FLUME-2151. Windows: Update TestExecSource to use native commands on Windows (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=1f21df7e11f5fe8a3dcd0bd34116289c02943a64)

          • flume-ng-core/src/test/resources/test_command.ps1
          • flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
          Show
          Hudson added a comment - SUCCESS: Integrated in flume-trunk #563 (See https://builds.apache.org/job/flume-trunk/563/ ) FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo/?p=flume.git&a=commit&h=1f21df7e11f5fe8a3dcd0bd34116289c02943a64 ) flume-ng-core/src/test/resources/test_command.ps1 flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
          Hari Shreedharan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s v1.5.0 [ 12324642 ]
          Resolution Fixed [ 1 ]
          Hide
          Hari Shreedharan added a comment -

          Committed! Thanks Roshan

          Show
          Hari Shreedharan added a comment - Committed! Thanks Roshan
          Hide
          ASF subversion and git services added a comment -

          Commit 38d8377e912768e63fb518bbf6f65ede19b14618 in flume's branch refs/heads/flume-1.5 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=38d8377 ]

          FLUME-2151. Windows: Update TestExecSource to use native commands on Windows

          (Roshan Naik via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit 38d8377e912768e63fb518bbf6f65ede19b14618 in flume's branch refs/heads/flume-1.5 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=38d8377 ] FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (Roshan Naik via Hari Shreedharan)
          Hide
          ASF subversion and git services added a comment -

          Commit 1f21df7e11f5fe8a3dcd0bd34116289c02943a64 in flume's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=1f21df7 ]

          FLUME-2151. Windows: Update TestExecSource to use native commands on Windows

          (Roshan Naik via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit 1f21df7e11f5fe8a3dcd0bd34116289c02943a64 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=1f21df7 ] FLUME-2151 . Windows: Update TestExecSource to use native commands on Windows (Roshan Naik via Hari Shreedharan)
          Hide
          Hari Shreedharan added a comment -

          +1. Tested it on Mac and Linux. Works ok.

          Show
          Hari Shreedharan added a comment - +1. Tested it on Mac and Linux. Works ok.
          Hide
          Roshan Naik added a comment -

          Adding code review link

          Show
          Roshan Naik added a comment - Adding code review link
          Roshan Naik made changes -
          Remote Link This issue links to "Code Review (Web Link)" [ 14105 ]
          Hide
          Ashish Paliwal added a comment -

          Roshan Naik Can you please open a review request for the patch?
          I applied the patch, and the it works on windows. Have access to a windows machine for time being.

          Show
          Ashish Paliwal added a comment - Roshan Naik Can you please open a review request for the patch? I applied the patch, and the it works on windows. Have access to a windows machine for time being.
          Roshan Naik made changes -
          Attachment FLUME-2172.2.patch [ 12610263 ]
          Roshan Naik made changes -
          Attachment FLUME-2172.2.patch [ 12610263 ]
          Hide
          Roshan Naik added a comment -

          rebased patch

          Show
          Roshan Naik added a comment - rebased patch
          Roshan Naik made changes -
          Attachment FLUME-2151.patch [ 12596954 ]
          Hide
          Roshan Naik added a comment -

          updating patch. one file was missing in the patch.

          Show
          Roshan Naik added a comment - updating patch. one file was missing in the patch.
          Roshan Naik made changes -
          Attachment FLUME-2151.patch [ 12596745 ]
          Roshan Naik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Roshan Naik made changes -
          Attachment FLUME-2151.patch [ 12596745 ]
          Hide
          Roshan Naik added a comment -

          revised patch

          Show
          Roshan Naik added a comment - revised patch
          Roshan Naik made changes -
          Attachment FLUME-2151.patch [ 12596719 ]
          Roshan Naik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Roshan Naik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Roshan Naik made changes -
          Summary Windows: Fix testExecSource to use alternative commands on Windows Windows: Update TestExecSource to use native commands on Windows
          Roshan Naik made changes -
          Field Original Value New Value
          Attachment FLUME-2151.patch [ 12596719 ]
          Hide
          Roshan Naik added a comment -

          All tests have been updated to use windows commands on windows

          Show
          Roshan Naik added a comment - All tests have been updated to use windows commands on windows
          Roshan Naik created issue -

            People

            • Assignee:
              Roshan Naik
              Reporter:
              Roshan Naik
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development