Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.4.1
    • Fix Version/s: None
    • Component/s: Docs
    • Labels:

      Description

      Some of the section headings dont have spaces in the titles... like Elastic Search, Solr sink etc.

      Also need to note the type (non FQCN) for elasticsearch sink.

      1. FLUME-2122.patch
        7 kB
        Roshan Naik
      2. FLUME-2122.v2.patch
        7 kB
        Roshan Naik

        Activity

        Hide
        ejsarge Edward Sargisson added a comment -

        As I understand it, the formal name for the index is elasticsearch - all lower case.
        However elasticsearchsink looks weird in Flume land which is why I've been calling it ElasticSearchSink. I suppose one could argue for elasticsearch Sink.

        Show
        ejsarge Edward Sargisson added a comment - As I understand it, the formal name for the index is elasticsearch - all lower case. However elasticsearchsink looks weird in Flume land which is why I've been calling it ElasticSearchSink. I suppose one could argue for elasticsearch Sink.
        Hide
        roshan_naik Roshan Naik added a comment -

        Are you referring to the section heading ? If so, we could go with "Elasticsearch Sink".

        I see that on the elasticsearch website and docs that they do sometimes capitalize the E... particularly when starting a sentence.

        Show
        roshan_naik Roshan Naik added a comment - Are you referring to the section heading ? If so, we could go with "Elasticsearch Sink". I see that on the elasticsearch website and docs that they do sometimes capitalize the E... particularly when starting a sentence.
        Hide
        roshan_naik Roshan Naik added a comment -

        Revised patch capturing feedback from Edward

        Show
        roshan_naik Roshan Naik added a comment - Revised patch capturing feedback from Edward
        Hide
        ejsarge Edward Sargisson added a comment -

        I like it.
        Elasticsearch Sink seems to sit well in both Flume and elasticsearch.

        Nice work Roshan (and good catch on the FQCN->enum reversion).

        Show
        ejsarge Edward Sargisson added a comment - I like it. Elasticsearch Sink seems to sit well in both Flume and elasticsearch. Nice work Roshan (and good catch on the FQCN->enum reversion).

          People

          • Assignee:
            roshan_naik Roshan Naik
            Reporter:
            roshan_naik Roshan Naik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development