Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 1.3.0
-
Fix Version/s: 1.4.0
-
Component/s: Sinks+Sources, Windows
-
Labels:None
-
Environment:
Windows.
Description
Fix for FLUME-1373 (Remove hardcoded file separator in HDFSEventSink ) regressed the HDFS in Windows. The fix was done per PMD/Findbugs alert. The fix was to replace '/' with the OS file separator. The problem is that the code is not trying to build a local path; it's trying to combine strings to form a URI. In Linux, OS separator is '/' and this is not a problem. In windows, OS separator is '\' and therefore you end up with paths like hdfs://foo\var. The best fix would be to use URL objects but new URL("hdfs://..") throws unknown protocol HDFS. The most cost effective fix seems to be revert to hardcoding '/'
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
+1, looks good
Pushed to trunk and flume-1.4 branches. Thanks for the patch Pedro!
Integrated in flume-trunk #426 (See https://builds.apache.org/job/flume-trunk/426/)
FLUME-2032. HDFSEventSink doesn't work in Windows. (Revision a97c04657b4735d6759f7b66bc9b4df451ab3aab)
Result = SUCCESS
mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a97c04657b4735d6759f7b66bc9b4df451ab3aab
Files :
- flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
Could a comiter take a look at this changes?