Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1980

Log4jAppender should optionally drop events if append fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      We should allow a config to drop the event when append fails, rather than throwing an exception. Clients usually dont want the logging call to throw an exception and probably won't have code to handle this - especially when the code is some pre-packaged code and not their own.

      1. FLUME-1980.patch
        16 kB
        Hari Shreedharan

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in flume-trunk #409 (See https://builds.apache.org/job/flume-trunk/409/)
        FLUME-1980. Log4jAppender should optionally drop events if append fails. (Revision 40040326763cdc655ea2707d8cb90a46791192c8)

        Result = SUCCESS
        mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=40040326763cdc655ea2707d8cb90a46791192c8
        Files :

        • flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java
        • flume-ng-doc/sphinx/FlumeUserGuide.rst
        • flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java
        • flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java
        • flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java
        Show
        hudson Hudson added a comment - Integrated in flume-trunk #409 (See https://builds.apache.org/job/flume-trunk/409/ ) FLUME-1980 . Log4jAppender should optionally drop events if append fails. (Revision 40040326763cdc655ea2707d8cb90a46791192c8) Result = SUCCESS mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=40040326763cdc655ea2707d8cb90a46791192c8 Files : flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java flume-ng-doc/sphinx/FlumeUserGuide.rst flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java
        Hide
        mpercy Mike Percy added a comment -

        Pushed to trunk and flume-1.4 branches.

        Thanks for the patch Hari!

        Show
        mpercy Mike Percy added a comment - Pushed to trunk and flume-1.4 branches. Thanks for the patch Hari!
        Hide
        mpercy Mike Percy added a comment -

        +1, looks good, let's get this in

        Show
        mpercy Mike Percy added a comment - +1, looks good, let's get this in
        Hide
        rvs Roman Shaposhnik added a comment -

        +1 (non-bidning).

        Show
        rvs Roman Shaposhnik added a comment - +1 (non-bidning).
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Removed a file accidentally added file in the last patc

        Show
        hshreedharan Hari Shreedharan added a comment - Removed a file accidentally added file in the last patc

          People

          • Assignee:
            hshreedharan Hari Shreedharan
            Reporter:
            hshreedharan Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development