Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1976

JMS Source document should provide instruction on JMS implementation jars

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      The JMS Source should instruct/remind users that they will have to place their vendor supplied JMS jars in the flume classpath to utilize the JMS source.

      1. FLUME-1976.patch
        0.8 kB
        Roshan Naik
      2. FLUME-1976.patch
        0.7 kB
        Roshan Naik

        Activity

        Hide
        roshan_naik Roshan Naik added a comment -

        adding note on classpath needs for JMS source in user doc

        Show
        roshan_naik Roshan Naik added a comment - adding note on classpath needs for JMS source in user doc
        Hide
        brocknoland Brock Noland added a comment -

        Hi,

        I think "to flume event converter." should be "flume event converter." I believe that was my mistake

        "Note that the vendor provided JMS jars should be included in the Flume classpath using the --classpath command line argument."

        We should mention all three options: plugin.d directory (preferred), --classpath, or via FLUME_CLASSPATH in flume-env.sh.

        Show
        brocknoland Brock Noland added a comment - Hi, I think "to flume event converter." should be "flume event converter." I believe that was my mistake "Note that the vendor provided JMS jars should be included in the Flume classpath using the --classpath command line argument." We should mention all three options: plugin.d directory (preferred), --classpath, or via FLUME_CLASSPATH in flume-env.sh.
        Hide
        roshan_naik Roshan Naik added a comment - - edited

        > I think "to flume event converter." should be "flume event converter." I believe that was my mistake

        It seems ok to me. The phrase ", message to flume event converter" seems more correct than ", message flume event converter" ... isnt it ?

        WRT plugin.d dir : i dont see any references to this directory anywhere else in the docs nor in the startup script

        Show
        roshan_naik Roshan Naik added a comment - - edited > I think "to flume event converter." should be "flume event converter." I believe that was my mistake It seems ok to me. The phrase ", message to flume event converter" seems more correct than ", message flume event converter" ... isnt it ? WRT plugin.d dir : i dont see any references to this directory anywhere else in the docs nor in the startup script
        Hide
        brocknoland Brock Noland added a comment -

        It seems ok to me.

        Sorry, I misread!

        RT plugin.d dir : i dont see any references to this directory anywhere else nor in the startup script

        https://github.com/apache/flume/blob/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst#installing-third-party-plugins
        https://github.com/apache/flume/blob/trunk/bin/flume-ng#L349

        Show
        brocknoland Brock Noland added a comment - It seems ok to me. Sorry, I misread! RT plugin.d dir : i dont see any references to this directory anywhere else nor in the startup script https://github.com/apache/flume/blob/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst#installing-third-party-plugins https://github.com/apache/flume/blob/trunk/bin/flume-ng#L349
        Hide
        roshan_naik Roshan Naik added a comment -

        oh.. i was was grepping for 'plugin.d'

        Show
        roshan_naik Roshan Naik added a comment - oh.. i was was grepping for 'plugin.d'
        Hide
        roshan_naik Roshan Naik added a comment -

        incorporating Brock's feedback

        Show
        roshan_naik Roshan Naik added a comment - incorporating Brock's feedback
        Hide
        mpercy Mike Percy added a comment -

        +1, looks good.

        Show
        mpercy Mike Percy added a comment - +1, looks good.
        Hide
        mpercy Mike Percy added a comment -

        Pushed to trunk and flume-1.4 branches. Thanks Roshan!

        Show
        mpercy Mike Percy added a comment - Pushed to trunk and flume-1.4 branches. Thanks Roshan!
        Hide
        hudson Hudson added a comment -

        Integrated in flume-trunk #426 (See https://builds.apache.org/job/flume-trunk/426/)
        FLUME-1976. JMS Source document should provide instruction on JMS implementation jars. (Revision 7eb9acc503b01b8c298f457b6d95575022af821d)

        Result = SUCCESS
        mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=7eb9acc503b01b8c298f457b6d95575022af821d
        Files :

        • flume-ng-doc/sphinx/FlumeUserGuide.rst
        Show
        hudson Hudson added a comment - Integrated in flume-trunk #426 (See https://builds.apache.org/job/flume-trunk/426/ ) FLUME-1976 . JMS Source document should provide instruction on JMS implementation jars. (Revision 7eb9acc503b01b8c298f457b6d95575022af821d) Result = SUCCESS mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=7eb9acc503b01b8c298f457b6d95575022af821d Files : flume-ng-doc/sphinx/FlumeUserGuide.rst

          People

          • Assignee:
            roshan_naik Roshan Naik
            Reporter:
            brocknoland Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development