I have created a patch for this.

Will be attaching the patch shortly.

Israel, very nice! This is a great start.

Some suggestions:
1. It would be great to add this generic logging functionality to MonitoredCounterGroup
2. Do the same as you did with ChannelCounter to SourceCounter and SinkCounter and just call the above impl from stop()
3. It would be great to sort the metric key names before printing. As an example:

List<String> keys = new ArrayList<String>(getCounterMap().keySet());
Collections.sort(keys);
for (String key : keys) { ... }

4. Nit: minor indentation issue in the new MonitoredCounterGroup.getName() method (but you may not need to expose that if the impl is there)
5. It would be great to also post this patch on https://reviews.apache.org/ per https://cwiki.apache.org/confluence/display/FLUME/How+to+Contribute#HowtoContribute-ProvidingPatches - use group Flume - and cross-link them. See other reviews at https://reviews.apache.org/groups/Flume/ as an example

Thanks!

Hi Israel, any update on this one?

Thanks,
Mike

I started working on them last weekend.

I should have a patch ready for review within the next 3 days.

I think this issue will supersede FLUME-1957 when it is resolved and closed.

Sounds great!

I plan to finish this either tonight or tomorrow night.

I will put up the patch for review.

This is the updated patch.

The review is available here

https://reviews.apache.org/r/10416/

Temporarily cancelling patch available due to RB feedback

The updated patch has been submitted for review

+1

Thanks for the patch Israel! Pushed to trunk and flume-1.4 branches.

Integrated in flume-trunk #399 (See https://builds.apache.org/job/flume-trunk/399/)
FLUME-1940. Log a snapshot of Flume metrics on shutdown. (Revision 215d75eb15362f34cd3246107cbea7ace247af10)

Result = UNSTABLE
mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=215d75eb15362f34cd3246107cbea7ace247af10
Files :

• flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java