Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: Docs, Sinks+Sources
    • Labels:
    • Environment:

      Ubuntu 12.10

    • Release Note:
      Test Case added for IRC Sink

      Description

      IRCSink.java does not initialize splitlines to a default value if it is not contained in the config. It does check if splitChars is NULL, and initialize it to the default constant, but it does not do so for splitlines.

      The user guide found here does show that splitlines has no default value, but it is not bold (indicating it must be defined in the config).

      Obviously if splitlines is not configured, you'll get a NPE when sendLine is called, since it does not check for NULL values either.

      1. FLUME-1281-1892-0.patch
        9 kB
        Ashish Paliwal
      2. FLUME-1892-0.patch
        6 kB
        Ashish Paliwal
      3. FLUME-1892-1.patch
        6 kB
        Ashish Paliwal

        Issue Links

          Activity

          Hide
          paliwalashish Ashish Paliwal added a comment -

          Patch

          Show
          paliwalashish Ashish Paliwal added a comment - Patch
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Gentle reminder to help with Review

          Show
          paliwalashish Ashish Paliwal added a comment - Gentle reminder to help with Review
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Split the patch specific to 1892

          Show
          paliwalashish Ashish Paliwal added a comment - Split the patch specific to 1892
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Hari Shreedharan Can you please look at the patch. It's a minor one, and it unblocks another JIRA

          Show
          paliwalashish Ashish Paliwal added a comment - Hari Shreedharan Can you please look at the patch. It's a minor one, and it unblocks another JIRA
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. I am unable to attach the patch though (the new file seems to be not applying). git apply does not seem to help.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. I am unable to attach the patch though (the new file seems to be not applying). git apply does not seem to help.
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Same problem like Scribe JIRA. I added the file with git add -N fileName

          Any suggestions?

          Show
          paliwalashish Ashish Paliwal added a comment - Same problem like Scribe JIRA. I added the file with git add -N fileName Any suggestions?
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Doing git diff trunk should be good.

          Show
          hshreedharan Hari Shreedharan added a comment - Doing git diff trunk should be good.
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Updated diff with git diff trunk

          Show
          paliwalashish Ashish Paliwal added a comment - Updated diff with git diff trunk
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Hari Shreedharan Can you please try with -1 patch.

          Show
          paliwalashish Ashish Paliwal added a comment - Hari Shreedharan Can you please try with -1 patch.
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. Committing.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. Committing.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fa3fb3deaa1045d0c6ebbd18630fa268f5db7fc1 in branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=fa3fb3d ]

          FLUME-1892. Fix NullPointerException in IRC Sink.

          (Ashish Paliwal via Hari Shreedharan)

          Show
          jira-bot ASF subversion and git services added a comment - Commit fa3fb3deaa1045d0c6ebbd18630fa268f5db7fc1 in branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=fa3fb3d ] FLUME-1892 . Fix NullPointerException in IRC Sink. (Ashish Paliwal via Hari Shreedharan)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8467f8e315ba4f2004e0b7e1711c70367d5b0b45 in branch refs/heads/flume-1.5 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=8467f8e ]

          FLUME-1892. Fix NullPointerException in IRC Sink.

          (Ashish Paliwal via Hari Shreedharan)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8467f8e315ba4f2004e0b7e1711c70367d5b0b45 in branch refs/heads/flume-1.5 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=8467f8e ] FLUME-1892 . Fix NullPointerException in IRC Sink. (Ashish Paliwal via Hari Shreedharan)
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Committed. Thanks Ashish!

          Show
          hshreedharan Hari Shreedharan added a comment - Committed. Thanks Ashish!
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Thanks a ton Hari!

          This unblocks other JIRA. I shall submit the patch today.

          Show
          paliwalashish Ashish Paliwal added a comment - Thanks a ton Hari! This unblocks other JIRA. I shall submit the patch today.
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in flume-trunk #543 (See https://builds.apache.org/job/flume-trunk/543/)
          FLUME-1892. Fix NullPointerException in IRC Sink. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=fa3fb3deaa1045d0c6ebbd18630fa268f5db7fc1)

          • flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java
          • flume-ng-sinks/flume-irc-sink/src/test/java/org/apache/flume/sink/irc/TestIRCSink.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in flume-trunk #543 (See https://builds.apache.org/job/flume-trunk/543/ ) FLUME-1892 . Fix NullPointerException in IRC Sink. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=fa3fb3deaa1045d0c6ebbd18630fa268f5db7fc1 ) flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java flume-ng-sinks/flume-irc-sink/src/test/java/org/apache/flume/sink/irc/TestIRCSink.java

            People

            • Assignee:
              paliwalashish Ashish Paliwal
              Reporter:
              jcollell Jeff Collell
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development