Details
Bug
Minor
Description
When using Sequence source, ChannelExceptions arising from puts do not leave behind any log messages.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Roshan,
Shouldn't this be logged in sequence source? The other sources log this error which will cause lots of double logging.
+10 on somehow getting seq source to log exceptions, was hit by this myself
Brock
Yeah thats a possiblity too. I wondered whats might be right thing. It seems like ChannelProcessor is already doing some logging some exceptions (not all) in that same path so this patch seemed natural.
Its trivial to add that log message in the SequenceGenerator source too.
Brock.. Should i revise this patch and move the logging into Seq source instead ?
Hi,
That would be great!
Logging error in response to Channel Exception in Sequence Generator source.
Brock, this one should be ready for commit.
Thanks Roshan! Committed to trunk and 1.4!
Integrated in flume-trunk #388 (See https://builds.apache.org/job/flume-trunk/388/)
FLUME-1866: ChannelProcessor is not logging ChannelExceptions (Revision df7a197a51bdb326149255fdad4db01ca886ba57)
Result = FAILURE
brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=df7a197a51bdb326149255fdad4db01ca886ba57
Files :
- flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
Just one line change to add to log error.