Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1866

ChannelProcessor is not logging ChannelExceptions.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.4.0
    • Component/s: Channel
    • Labels:
      None

      Description

      When using Sequence source, ChannelExceptions arising from puts do not leave behind any log messages.

      1. 1866.patch.v2
        0.7 kB
        Roshan Naik
      2. 1866.patch
        0.7 kB
        Roshan Naik

        Activity

        Hide
        roshan_naik Roshan Naik added a comment -

        Just one line change to add to log error.

        Show
        roshan_naik Roshan Naik added a comment - Just one line change to add to log error.
        Hide
        brocknoland Brock Noland added a comment -

        Roshan,

        Shouldn't this be logged in sequence source? The other sources log this error which will cause lots of double logging.

        +10 on somehow getting seq source to log exceptions, was hit by this myself

        Brock

        Show
        brocknoland Brock Noland added a comment - Roshan, Shouldn't this be logged in sequence source? The other sources log this error which will cause lots of double logging. +10 on somehow getting seq source to log exceptions, was hit by this myself Brock
        Hide
        roshan_naik Roshan Naik added a comment -

        Yeah thats a possiblity too. I wondered whats might be right thing. It seems like ChannelProcessor is already doing some logging some exceptions (not all) in that same path so this patch seemed natural.

        Its trivial to add that log message in the SequenceGenerator source too.

        Show
        roshan_naik Roshan Naik added a comment - Yeah thats a possiblity too. I wondered whats might be right thing. It seems like ChannelProcessor is already doing some logging some exceptions (not all) in that same path so this patch seemed natural. Its trivial to add that log message in the SequenceGenerator source too.
        Hide
        roshan_naik Roshan Naik added a comment -

        Brock.. Should i revise this patch and move the logging into Seq source instead ?

        Show
        roshan_naik Roshan Naik added a comment - Brock.. Should i revise this patch and move the logging into Seq source instead ?
        Hide
        brocknoland Brock Noland added a comment -

        Hi,

        That would be great!

        Show
        brocknoland Brock Noland added a comment - Hi, That would be great!
        Hide
        roshan_naik Roshan Naik added a comment -

        Logging error in response to Channel Exception in Sequence Generator source.

        Show
        roshan_naik Roshan Naik added a comment - Logging error in response to Channel Exception in Sequence Generator source.
        Hide
        roshan_naik Roshan Naik added a comment -

        Brock, this one should be ready for commit.

        Show
        roshan_naik Roshan Naik added a comment - Brock, this one should be ready for commit.
        Hide
        brocknoland Brock Noland added a comment -

        Thanks Roshan! Committed to trunk and 1.4!

        Show
        brocknoland Brock Noland added a comment - Thanks Roshan! Committed to trunk and 1.4!
        Hide
        hudson Hudson added a comment -

        Integrated in flume-trunk #388 (See https://builds.apache.org/job/flume-trunk/388/)
        FLUME-1866: ChannelProcessor is not logging ChannelExceptions (Revision df7a197a51bdb326149255fdad4db01ca886ba57)

        Result = FAILURE
        brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=df7a197a51bdb326149255fdad4db01ca886ba57
        Files :

        • flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
        Show
        hudson Hudson added a comment - Integrated in flume-trunk #388 (See https://builds.apache.org/job/flume-trunk/388/ ) FLUME-1866 : ChannelProcessor is not logging ChannelExceptions (Revision df7a197a51bdb326149255fdad4db01ca886ba57) Result = FAILURE brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=df7a197a51bdb326149255fdad4db01ca886ba57 Files : flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java

          People

          • Assignee:
            roshan_naik Roshan Naik
            Reporter:
            roshan_naik Roshan Naik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development