Flume
  1. Flume
  2. FLUME-1787

Implement Pre-commit testing with Jenkins

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Hadoop does pre-commit testing. It'd be nice if we could do the same. This was discussed here: http://markmail.org/message/ie4zrpv4kviu6n4y

        Issue Links

          Activity

          Brock Noland created issue -
          Brock Noland made changes -
          Field Original Value New Value
          Attachment FLUME-1787-0.patch [ 12561794 ]
          Brock Noland made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561805 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561805 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561848 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561848 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561968 ]
          Brock Noland made changes -
          Attachment FLUME-1787-3.patch [ 12561969 ]
          Brock Noland made changes -
          Attachment FLUME-1787-4.patch [ 12562001 ]
          Brock Noland made changes -
          Attachment FLUME-1787-0.patch [ 12561794 ]
          Brock Noland made changes -
          Attachment FLUME-1787-1.patch [ 12561968 ]
          Brock Noland made changes -
          Attachment FLUME-1787-3.patch [ 12561969 ]
          Brock Noland made changes -
          Attachment FLUME-1787-4.patch [ 12562001 ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ test patch ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ This is a test, only a test. ]
          Brock Noland made changes -
          Comment [ -1 overall -1 failed to apply patch (exit code 1) ]
          Brock Noland made changes -
          Comment [ * -1 overall* -1 failed to apply patch (exit code 1) ]
          Brock Noland made changes -
          Comment [ -1 overall

           -1 failed to apply patch (exit code 1) ]
          Brock Noland made changes -
          Comment [  {color:red}-1 overall{color}
           {color:red}-1 failed to apply patch (exit code 1){color}
          ]
          Brock Noland made changes -
          Comment [  {color:red}-1{color} overall

           {color:red}-1{color} failed to apply patch (exit code 1)
          ]
          Brock Noland made changes -
          Comment [  {color:red}-1 failed to apply patch (exit code 1){color}
          ]
          Brock Noland made changes -
          Comment [ Patch applied and built but tests did not execute
          ]
          Brock Noland made changes -
          Comment [  {color:green}+1 all tests passed{color}
          ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561794/FLUME-1787-0.patch against trunk.

           {color:red}FATAL: failed to apply patch (exit code 1){color}
           {color:green}+1 all tests passed{color}

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561794/FLUME-1787-0.patch against trunk.

           {color:red}-1 due to 1 errors{color}

           {color:red}failed to apply patch (exit code 1){color}
          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561794/FLUME-1787-0.patch against trunk.

          Overall: {color:red}-1 due to 1 error(s){color}

          Error: {color:red}failed to apply patch (exit code 1){color}

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561794/FLUME-1787-0.patch against trunk.

          {color:red}Overall:{color} -1 due to 1 error(s)

          {color:red}Error:{color} failed to apply patch (exit code 1)

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against trunk.

          {color:green}Overall:{color} +1 all tests passed

          {color:green}Success:{color} all tests passed

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ "+1 all tests passed" should be "+1 all checks pass" ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against trunk.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to build with patch (exit code 2)
          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/7//console


          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to build with patch (exit code 1)

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:green}Overall:{color} +1 all checks pass

          {color:green}SUCCESS:{color} all tests passed

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachement
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to clean project (exit code 127

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/8/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to build with patch (exit code 1)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/9/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to clean project (exit code 127)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/10/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to build with patch (exit code 1)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/11/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to build with patch (exit code 1)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/12/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561848/FLUME-1787-1.patch against trunk.

          {color:green}Overall:{color} +1 all checks pass

          {color:green}SUCCESS:{color} all tests passed

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to clean project (exit code 127)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/14/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to clean project (exit code 127)

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/15/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} git merge failed

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/16/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} git merge failed

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/17/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} git merge failed

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/18/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12561969/FLUME-1787-3.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to an error

          {color:red}ERROR:{color} failed to apply patch (exit code 1):
          error: flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java: No such file or directory



          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/20/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12562001/FLUME-1787-4.patch against FLUME-1787.

          {color:red}Overall:{color} -1 due to 2 errors

          {color:red}ERROR:{color} mvn test exited 1
          {color:red}ERROR:{color} Failed: org.apache.flume.source.TestMultiportSyslogTCPSource

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/21/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Comment [ Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12562001/FLUME-1787-4.patch against FLUME-1787.

          {color:green}Overall:{color} +1 all checks pass

          {color:green}SUCCESS:{color} all tests passed

          Console output: https://builds.apache.org/job/PreCommit-FLUME-Build/22/console

          This message is automatically generated. ]
          Brock Noland made changes -
          Remote Link This issue links to "Review Board (Web Link)" [ 11925 ]
          Brock Noland made changes -
          Attachment FLUME-1787-0.patch [ 12562011 ]
          Brock Noland made changes -
          Description Hadoop does pre-commit testing. It'd be nice if we could do the same.
          Hide
          Brock Noland added a comment -

          I have a build setup to use the attached script. I have manually tested it but we need to commit it to trunk to do the final test and before enabling our pre-commit build which is located here: https://builds.apache.org/job/PreCommit-FLUME-Build/

          Show
          Brock Noland added a comment - I have a build setup to use the attached script. I have manually tested it but we need to commit it to trunk to do the final test and before enabling our pre-commit build which is located here: https://builds.apache.org/job/PreCommit-FLUME-Build/
          Brock Noland made changes -
          Description Hadoop does pre-commit testing. It'd be nice if we could do the same. Hadoop does pre-commit testing. It'd be nice if we could do the same. This was discussed here: http://markmail.org/message/ie4zrpv4kviu6n4y
          Hide
          Brock Noland added a comment -
          Show
          Brock Noland added a comment - FWIW, here is Hadoop's script https://github.com/apache/hadoop-common/blob/trunk/dev-support/test-patch.sh
          Hide
          Hari Shreedharan added a comment -

          Hey Brock,

          Is this ready for commit?

          Show
          Hari Shreedharan added a comment - Hey Brock, Is this ready for commit?
          Hide
          Hari Shreedharan added a comment -

          Looks like it is and does not seem to affect any existing code. +1.

          Show
          Hari Shreedharan added a comment - Looks like it is and does not seem to affect any existing code. +1.
          Hide
          Hari Shreedharan added a comment -

          Committed to trunk and flume-1.4, rev: c0c4947. Thanks Brock!

          Show
          Hari Shreedharan added a comment - Committed to trunk and flume-1.4, rev: c0c4947. Thanks Brock!
          Hari Shreedharan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Brock Noland added a comment -

          Thanks Hari! I did notice that one file, atlassian-ide-plugin got committed and wasn't in the patch AFAIK.

          Show
          Brock Noland added a comment - Thanks Hari! I did notice that one file, atlassian-ide-plugin got committed and wasn't in the patch AFAIK.
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #384 (See https://builds.apache.org/job/flume-trunk/384/)
          FLUME-1787. Implement Pre-commit testing with Jenkins. (Revision c0c4947b295013d051dad98c07b87deaa9427af2)

          Result = FAILURE
          hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c0c4947b295013d051dad98c07b87deaa9427af2
          Files :

          • pom.xml
          • dev-support/test-patch.py
          • .gitignore
          • atlassian-ide-plugin.xml
          Show
          Hudson added a comment - Integrated in flume-trunk #384 (See https://builds.apache.org/job/flume-trunk/384/ ) FLUME-1787 . Implement Pre-commit testing with Jenkins. (Revision c0c4947b295013d051dad98c07b87deaa9427af2) Result = FAILURE hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c0c4947b295013d051dad98c07b87deaa9427af2 Files : pom.xml dev-support/test-patch.py .gitignore atlassian-ide-plugin.xml
          Mike Percy made changes -
          Fix Version/s v1.3.0 [ 12322140 ]
          Brock Noland made changes -
          Link This issue is related to HIVE-4862 [ HIVE-4862 ]

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development