Flume
  1. Flume
  2. FLUME-1787

Implement Pre-commit testing with Jenkins

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Hadoop does pre-commit testing. It'd be nice if we could do the same. This was discussed here: http://markmail.org/message/ie4zrpv4kviu6n4y

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in flume-trunk #384 (See https://builds.apache.org/job/flume-trunk/384/)
          FLUME-1787. Implement Pre-commit testing with Jenkins. (Revision c0c4947b295013d051dad98c07b87deaa9427af2)

          Result = FAILURE
          hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c0c4947b295013d051dad98c07b87deaa9427af2
          Files :

          • pom.xml
          • dev-support/test-patch.py
          • .gitignore
          • atlassian-ide-plugin.xml
          Show
          Hudson added a comment - Integrated in flume-trunk #384 (See https://builds.apache.org/job/flume-trunk/384/ ) FLUME-1787 . Implement Pre-commit testing with Jenkins. (Revision c0c4947b295013d051dad98c07b87deaa9427af2) Result = FAILURE hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=c0c4947b295013d051dad98c07b87deaa9427af2 Files : pom.xml dev-support/test-patch.py .gitignore atlassian-ide-plugin.xml
          Hide
          Brock Noland added a comment -

          Thanks Hari! I did notice that one file, atlassian-ide-plugin got committed and wasn't in the patch AFAIK.

          Show
          Brock Noland added a comment - Thanks Hari! I did notice that one file, atlassian-ide-plugin got committed and wasn't in the patch AFAIK.
          Hide
          Hari Shreedharan added a comment -

          Committed to trunk and flume-1.4, rev: c0c4947. Thanks Brock!

          Show
          Hari Shreedharan added a comment - Committed to trunk and flume-1.4, rev: c0c4947. Thanks Brock!
          Hide
          Hari Shreedharan added a comment -

          Looks like it is and does not seem to affect any existing code. +1.

          Show
          Hari Shreedharan added a comment - Looks like it is and does not seem to affect any existing code. +1.
          Hide
          Hari Shreedharan added a comment -

          Hey Brock,

          Is this ready for commit?

          Show
          Hari Shreedharan added a comment - Hey Brock, Is this ready for commit?
          Hide
          Brock Noland added a comment -
          Show
          Brock Noland added a comment - FWIW, here is Hadoop's script https://github.com/apache/hadoop-common/blob/trunk/dev-support/test-patch.sh
          Hide
          Brock Noland added a comment -

          I have a build setup to use the attached script. I have manually tested it but we need to commit it to trunk to do the final test and before enabling our pre-commit build which is located here: https://builds.apache.org/job/PreCommit-FLUME-Build/

          Show
          Brock Noland added a comment - I have a build setup to use the attached script. I have manually tested it but we need to commit it to trunk to do the final test and before enabling our pre-commit build which is located here: https://builds.apache.org/job/PreCommit-FLUME-Build/

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development