Flume
  1. Flume
  2. FLUME-1777

AbstractSource does not provide enough implementation for sub-classes

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.3.0
    • Fix Version/s: v1.4.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      AbstractSource is a raw interface requiring sources to implement a fair amount of items which it could implement for all subclasses. However, many classes extend it and as such changing it would be incompatible.

      1. FLUME-1777-0.patch
        17 kB
        Brock Noland
      2. FLUME-1777-1.patch
        17 kB
        Brock Noland

        Issue Links

          Activity

          Brock Noland created issue -
          Brock Noland made changes -
          Field Original Value New Value
          Description AbstractSource is a pretty raw interface. However, many classes extend it and as such changing it would be incompatible.
          Brock Noland made changes -
          Description AbstractSource is a pretty raw interface. However, many classes extend it and as such changing it would be incompatible. AbstractSource is a raw interface requiring sources to implement a fair amount of items which it could implement for all subclasses. However, many classes extend it and as such changing it would be incompatible.
          Hide
          Brock Noland added a comment -

          I'd like to see a new abstract source class, say BasicSourceSemantics (named similar to the Channel abstract classes) which sets the life cycle state appropriate, doesn't require the use of super, and allows subclasses to set the lifecycle state.

          Show
          Brock Noland added a comment - I'd like to see a new abstract source class, say BasicSourceSemantics (named similar to the Channel abstract classes) which sets the life cycle state appropriate, doesn't require the use of super, and allows subclasses to set the lifecycle state.
          Hide
          Brock Noland added a comment -

          Patch from Review Board.

          Show
          Brock Noland added a comment - Patch from Review Board.
          Brock Noland made changes -
          Attachment FLUME-1777-0.patch [ 12560637 ]
          Brock Noland made changes -
          Link This issue blocks FLUME-924 [ FLUME-924 ]
          Brock Noland made changes -
          Remote Link This issue links to "Review Board (Web Link)" [ 11827 ]
          Hide
          Brock Noland added a comment -

          Patch from RB

          Show
          Brock Noland added a comment - Patch from RB
          Brock Noland made changes -
          Attachment FLUME-1777-1.patch [ 12560785 ]
          Hide
          Hari Shreedharan added a comment -

          +1. Will run tests and commit.

          Show
          Hari Shreedharan added a comment - +1. Will run tests and commit.
          Hide
          Hari Shreedharan added a comment -

          Patch committed, rev: 5b636c1237f51dc0a8a9c2b589747e0477dbb5fc. Thanks Brock!

          Show
          Hari Shreedharan added a comment - Patch committed, rev: 5b636c1237f51dc0a8a9c2b589747e0477dbb5fc. Thanks Brock!
          Hari Shreedharan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Brock Noland [ brocknoland ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #340 (See https://builds.apache.org/job/flume-trunk/340/)
          FLUME-1777. AbstractSource does not provide enough implementation for sub-classes (Revision 5b636c1237f51dc0a8a9c2b589747e0477dbb5fc)

          Result = SUCCESS
          hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=5b636c1237f51dc0a8a9c2b589747e0477dbb5fc
          Files :

          • flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java
          • flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
          • flume-ng-core/src/main/java/org/apache/flume/source/AbstractEventDrivenSource.java
          • flume-ng-core/src/test/java/org/apache/flume/source/TestBasicSourceSemantics.java
          • flume-ng-core/src/main/java/org/apache/flume/source/BasicSourceSemantics.java
          • flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java
          Show
          Hudson added a comment - Integrated in flume-trunk #340 (See https://builds.apache.org/job/flume-trunk/340/ ) FLUME-1777 . AbstractSource does not provide enough implementation for sub-classes (Revision 5b636c1237f51dc0a8a9c2b589747e0477dbb5fc) Result = SUCCESS hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=5b636c1237f51dc0a8a9c2b589747e0477dbb5fc Files : flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java flume-ng-core/src/main/java/org/apache/flume/source/AbstractEventDrivenSource.java flume-ng-core/src/test/java/org/apache/flume/source/TestBasicSourceSemantics.java flume-ng-core/src/main/java/org/apache/flume/source/BasicSourceSemantics.java flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java
          Hari Shreedharan made changes -
          Fix Version/s v1.4.0 [ 12323372 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          23h 19m 1 Hari Shreedharan 13/Dec/12 20:08

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development