Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1773

File Channel worker thread should not be daemon

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.4.0, 1.3.1
        • Component/s: None
        • Labels:
          None

          Description

          The worker thread should be a normal thread - we should give it a few seconds to stop.

          1. Text File
            FLUME-1773.patch
            5 kB
            Hari Shreedharan
          2. Text File
            FLUME-1773-2.patch
            5 kB
            Hari Shreedharan
          3. Text File
            FLUME-1773-3.patch
            5 kB
            Hari Shreedharan

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. FLUME-1775 FileChannel Log Background worker should catch Throwable

            • Major - Major loss of function.
            • Resolved
            links to

            Web Link Review

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              hshreedharan Hari Shreedharan added a comment -

              There are a couple of things we should change, maybe later. In Log class, this is being leaked out in the constructor, also a thread is being scheduled. Both these will cause issues if we choose to inherit from the Log class later.

              Show
              hshreedharan Hari Shreedharan added a comment - There are a couple of things we should change, maybe later. In Log class, this is being leaked out in the constructor, also a thread is being scheduled. Both these will cause issues if we choose to inherit from the Log class later.
              Hide
              Permalink
              brocknoland Brock Noland added a comment -

              Hi,

              Yeah I don't see any reason to change that until we want to extend the Log class at which point it will be quite easy to change. Can you link this JIRA to the Review Board Item?

              Brock

              Show
              brocknoland Brock Noland added a comment - Hi, Yeah I don't see any reason to change that until we want to extend the Log class at which point it will be quite easy to change. Can you link this JIRA to the Review Board Item? Brock
              Hide
              Permalink
              brocknoland Brock Noland added a comment -

              Also, this patch ignores checkpointInterval which should be used or deprecated.

              Show
              brocknoland Brock Noland added a comment - Also, this patch ignores checkpointInterval which should be used or deprecated.
              Hide
              Permalink
              hshreedharan Hari Shreedharan added a comment -

              Brock - good catch. The new patch uses the checkpointInterval property to schedule the thread

              Show
              hshreedharan Hari Shreedharan added a comment - Brock - good catch. The new patch uses the checkpointInterval property to schedule the thread
              Hide
              Permalink
              brocknoland Brock Noland added a comment -

              Thanks for the patch Hari! Committed to trunk and 1.4!

              Show
              brocknoland Brock Noland added a comment - Thanks for the patch Hari! Committed to trunk and 1.4!
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/)
              FLUME-1773: File Channel worker thread should not be daemon (Revision e45d2fa33a23aee6d066bd0a4147cb215afa98c4)

              Result = SUCCESS
              brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e45d2fa33a23aee6d066bd0a4147cb215afa98c4
              Files :

              • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
              Show
              hudson Hudson added a comment - Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/ ) FLUME-1773 : File Channel worker thread should not be daemon (Revision e45d2fa33a23aee6d066bd0a4147cb215afa98c4) Result = SUCCESS brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e45d2fa33a23aee6d066bd0a4147cb215afa98c4 Files : flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java

                People

                • Assignee:
                  hshreedharan Hari Shreedharan
                  Reporter:
                  hshreedharan Hari Shreedharan
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development