The worker thread should be a normal thread - we should give it a few seconds to stop.
FileChannel Log Background worker should catch Throwable
There are a couple of things we should change, maybe later. In Log class, this is being leaked out in the constructor, also a thread is being scheduled. Both these will cause issues if we choose to inherit from the Log class later.
Yeah I don't see any reason to change that until we want to extend the Log class at which point it will be quite easy to change. Can you link this JIRA to the Review Board Item?
Also, this patch ignores checkpointInterval which should be used or deprecated.
Brock - good catch. The new patch uses the checkpointInterval property to schedule the thread
Thanks for the patch Hari! Committed to trunk and 1.4!
Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/)
FLUME-1773: File Channel worker thread should not be daemon (Revision e45d2fa33a23aee6d066bd0a4147cb215afa98c4)
Result = SUCCESS
brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e45d2fa33a23aee6d066bd0a4147cb215afa98c4