Flume
  1. Flume
  2. FLUME-1773

File Channel worker thread should not be daemon

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.4.0, v1.3.1
    • Component/s: None
    • Labels:
      None

      Description

      The worker thread should be a normal thread - we should give it a few seconds to stop.

      1. FLUME-1773-3.patch
        5 kB
        Hari Shreedharan
      2. FLUME-1773-2.patch
        5 kB
        Hari Shreedharan
      3. FLUME-1773.patch
        5 kB
        Hari Shreedharan

        Issue Links

          Activity

          Hari Shreedharan created issue -
          Hari Shreedharan made changes -
          Field Original Value New Value
          Attachment FLUME-1773.patch [ 12560051 ]
          Hari Shreedharan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hari Shreedharan made changes -
          Assignee Hari Shreedharan [ hshreedharan ]
          Hide
          Hari Shreedharan added a comment -

          There are a couple of things we should change, maybe later. In Log class, this is being leaked out in the constructor, also a thread is being scheduled. Both these will cause issues if we choose to inherit from the Log class later.

          Show
          Hari Shreedharan added a comment - There are a couple of things we should change, maybe later. In Log class, this is being leaked out in the constructor, also a thread is being scheduled. Both these will cause issues if we choose to inherit from the Log class later.
          Hide
          Brock Noland added a comment -

          Hi,

          Yeah I don't see any reason to change that until we want to extend the Log class at which point it will be quite easy to change. Can you link this JIRA to the Review Board Item?

          Brock

          Show
          Brock Noland added a comment - Hi, Yeah I don't see any reason to change that until we want to extend the Log class at which point it will be quite easy to change. Can you link this JIRA to the Review Board Item? Brock
          Hide
          Brock Noland added a comment -

          Also, this patch ignores checkpointInterval which should be used or deprecated.

          Show
          Brock Noland added a comment - Also, this patch ignores checkpointInterval which should be used or deprecated.
          Hari Shreedharan made changes -
          Attachment FLUME-1773-2.patch [ 12560269 ]
          Hari Shreedharan made changes -
          Remote Link This issue links to "Review (Web Link)" [ 11813 ]
          Hari Shreedharan made changes -
          Attachment FLUME-1773-2.patch [ 12560269 ]
          Hari Shreedharan made changes -
          Attachment FLUME-1773-2.patch [ 12560270 ]
          Hari Shreedharan made changes -
          Attachment FLUME-1773-2.patch [ 12560270 ]
          Hari Shreedharan made changes -
          Attachment FLUME-1773-2.patch [ 12560273 ]
          Hide
          Hari Shreedharan added a comment -

          Brock - good catch. The new patch uses the checkpointInterval property to schedule the thread

          Show
          Hari Shreedharan added a comment - Brock - good catch. The new patch uses the checkpointInterval property to schedule the thread
          Hari Shreedharan made changes -
          Attachment FLUME-1773-3.patch [ 12560284 ]
          Hide
          Brock Noland added a comment -

          Thanks for the patch Hari! Committed to trunk and 1.4!

          Show
          Brock Noland added a comment - Thanks for the patch Hari! Committed to trunk and 1.4!
          Brock Noland made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s v1.4.0 [ 12323372 ]
          Resolution Fixed [ 1 ]
          Brock Noland made changes -
          Link This issue is related to FLUME-1775 [ FLUME-1775 ]
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/)
          FLUME-1773: File Channel worker thread should not be daemon (Revision e45d2fa33a23aee6d066bd0a4147cb215afa98c4)

          Result = SUCCESS
          brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e45d2fa33a23aee6d066bd0a4147cb215afa98c4
          Files :

          • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
          Show
          Hudson added a comment - Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/ ) FLUME-1773 : File Channel worker thread should not be daemon (Revision e45d2fa33a23aee6d066bd0a4147cb215afa98c4) Result = SUCCESS brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e45d2fa33a23aee6d066bd0a4147cb215afa98c4 Files : flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
          Hari Shreedharan made changes -
          Fix Version/s v1.3.1 [ 12323879 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          3h 14m 1 Hari Shreedharan 08/Dec/12 23:38
          Patch Available Patch Available Resolved Resolved
          2d 5m 1 Brock Noland 10/Dec/12 23:43

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              Hari Shreedharan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development