Flume
  1. Flume
  2. FLUME-1741

ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.4.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      This is actually a release blocker

      1. FLUME-1741-3.patch
        0.9 kB
        Mike Percy
      2. FLUME-1741-2.patch
        1 kB
        Jeff Lord
      3. FLUME-1741-1.patch
        1 kB
        Jeff Lord

        Issue Links

          Activity

          Hide
          Jeff Lord added a comment -

          Realize this sets the DEFAULT_TEMP_DIR as a constant to data. Wasn't able to find where this object is held in es. Please let me know if there is a more appropriate way to handle this.

          Show
          Jeff Lord added a comment - Realize this sets the DEFAULT_TEMP_DIR as a constant to data. Wasn't able to find where this object is held in es. Please let me know if there is a more appropriate way to handle this.
          Hide
          Brock Noland added a comment -

          I think that we should be setting path.data for in openLocalDiscoveryClient in ElasticSearchSink.

          this line

          node = NodeBuilder.nodeBuilder().client(true).local(true).node();

          could have a settings added to it.

          Show
          Brock Noland added a comment - I think that we should be setting path.data for in openLocalDiscoveryClient in ElasticSearchSink. this line node = NodeBuilder.nodeBuilder().client(true).local(true).node(); could have a settings added to it.
          Hide
          Jeff Lord added a comment -

          Ok. Thank you. Here is another way to do it.
          Write to target and that will be cleaned up by mvn clean.

          Show
          Jeff Lord added a comment - Ok. Thank you. Here is another way to do it. Write to target and that will be cleaned up by mvn clean.
          Hide
          Jeff Lord added a comment -

          @Brock Were you suggesting that I add the path setting in here and then just call this method?

          private void openLocalDiscoveryClient()

          { node = NodeBuilder.nodeBuilder().client(true).local(true).node(); client = node.client(); }
          Show
          Jeff Lord added a comment - @Brock Were you suggesting that I add the path setting in here and then just call this method? private void openLocalDiscoveryClient() { node = NodeBuilder.nodeBuilder().client(true).local(true).node(); client = node.client(); }
          Hide
          Brock Noland added a comment -

          Latest patch looks good!

          Show
          Brock Noland added a comment - Latest patch looks good!
          Hide
          Mike Percy added a comment -

          Marking as "Patch Available" so devs can query on open issues needing review when they are not on review board. This should probably also be posted to RB.

          Show
          Mike Percy added a comment - Marking as "Patch Available" so devs can query on open issues needing review when they are not on review board. This should probably also be posted to RB.
          Hide
          Mike Percy added a comment -

          Adding web link to RB

          Show
          Mike Percy added a comment - Adding web link to RB
          Hide
          Jeff Lord added a comment -

          Mike and Hari I don't think this one is an issue any longer.
          On latest trunk the data directory is not left behind.
          Can you please let me know if you observe different behavior?

          Show
          Jeff Lord added a comment - Mike and Hari I don't think this one is an issue any longer. On latest trunk the data directory is not left behind. Can you please let me know if you observe different behavior?
          Hide
          Hari Shreedharan added a comment -

          $ git clean -df
          Removing flume-ng-sinks/flume-ng-elasticsearch-sink/data/

          Looks like the directory still gets left behind

          Show
          Hari Shreedharan added a comment - $ git clean -df Removing flume-ng-sinks/flume-ng-elasticsearch-sink/data/ Looks like the directory still gets left behind
          Hide
          Hari Shreedharan added a comment -

          Note that it was without the patch on this jira that the directory was left behind

          Show
          Hari Shreedharan added a comment - Note that it was without the patch on this jira that the directory was left behind
          Hide
          Mike Percy added a comment -

          Hi Jeff, do you have time to update this patch? Still seeing the issue.

          Show
          Mike Percy added a comment - Hi Jeff, do you have time to update this patch? Still seeing the issue.
          Hide
          Mike Percy added a comment -

          Jeff I am applying a version of your patch and committing as RM. Attached here as FLUME-1741-3.patch

          Show
          Mike Percy added a comment - Jeff I am applying a version of your patch and committing as RM. Attached here as FLUME-1741 -3.patch
          Hide
          Mike Percy added a comment -

          Pushed to trunk and flume-1.4 branches.

          Show
          Mike Percy added a comment - Pushed to trunk and flume-1.4 branches.
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #443 (See https://builds.apache.org/job/flume-trunk/443/)
          FLUME-1741. ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around. (Revision 1e2261ce04c9725256b5e99812e04cc1ceb3d636)

          Result = UNSTABLE
          mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=1e2261ce04c9725256b5e99812e04cc1ceb3d636
          Files :

          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java
          Show
          Hudson added a comment - Integrated in flume-trunk #443 (See https://builds.apache.org/job/flume-trunk/443/ ) FLUME-1741 . ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around. (Revision 1e2261ce04c9725256b5e99812e04cc1ceb3d636) Result = UNSTABLE mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=1e2261ce04c9725256b5e99812e04cc1ceb3d636 Files : flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java

            People

            • Assignee:
              Jeff Lord
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development