Flume
  1. Flume
  2. FLUME-1713

Netcat source should allow for *not* returning "OK" upon receipt of each message

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: v1.2.0
    • Fix Version/s: v1.3.0
    • Component/s: Easy
    • Labels:

      Description

      Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.

      The default configuration setup should remain the same though.

        Activity

        Hide
        Rahul Ravindran added a comment -

        I grant license to Cloudera for inclusion in Cloudera works (as per the Apache License §5)

        Show
        Rahul Ravindran added a comment - I grant license to Cloudera for inclusion in Cloudera works (as per the Apache License §5)
        Hide
        Rahul Ravindran added a comment -
        Show
        Rahul Ravindran added a comment - Review board id: https://review.cloudera.org/r/2462/
        Hide
        Hari Shreedharan added a comment -

        Rahul Ravindran We use Apache Review Board for reviews. Please post the review on https://reviews.apache.org

        Show
        Hari Shreedharan added a comment - Rahul Ravindran We use Apache Review Board for reviews. Please post the review on https://reviews.apache.org
        Hide
        Mike Percy added a comment -

        Rahul, thanks for the patch! In addition to posting to the Apache review board, please also:
        1. Format your patch using "git diff" instead of "git format-patch".
        2. Include a unit test to verify that the functionality works.

        Show
        Mike Percy added a comment - Rahul, thanks for the patch! In addition to posting to the Apache review board, please also: 1. Format your patch using "git diff" instead of "git format-patch". 2. Include a unit test to verify that the functionality works.
        Hide
        Rahul Ravindran added a comment -
        Show
        Rahul Ravindran added a comment - Review board url: https://reviews.apache.org/r/8220/
        Hide
        Rahul Ravindran added a comment -

        Mike Percy: 1 and 2 done.

        Show
        Rahul Ravindran added a comment - Mike Percy : 1 and 2 done.
        Hide
        Rahul Ravindran added a comment -

        Final patch after incorporating Mike's comments

        Show
        Rahul Ravindran added a comment - Final patch after incorporating Mike's comments
        Hide
        Mike Percy added a comment -

        Patch committed. Thanks for your contribution, Rahul!

        Rev: e257e3db054d8a8282bfb14187f2dadf8e3c13e4

        Show
        Mike Percy added a comment - Patch committed. Thanks for your contribution, Rahul! Rev: e257e3db054d8a8282bfb14187f2dadf8e3c13e4
        Hide
        Rahul Ravindran added a comment -

        Is there any way to get a patch of this change for v1.3? We plan to deploy prior to 1.4, and I would really prefer not to build our own version of v1.3.

        Show
        Rahul Ravindran added a comment - Is there any way to get a patch of this change for v1.3? We plan to deploy prior to 1.4, and I would really prefer not to build our own version of v1.3.
        Hide
        Mike Percy added a comment -

        Feel free to bring it up in the 1.3 VOTE thread on the Dev list

        Show
        Mike Percy added a comment - Feel free to bring it up in the 1.3 VOTE thread on the Dev list
        Hide
        Mike Percy added a comment -

        FWIW I'm +1 on this low risk change if we decide to roll another RC but it's up to the RM.

        Show
        Mike Percy added a comment - FWIW I'm +1 on this low risk change if we decide to roll another RC but it's up to the RM.
        Hide
        Rahul Ravindran added a comment -

        Mike Percy, I just joined the dev list and don't seem to be able to respond to an older thread. Would be thankful if you could bring this up in the 1.3 VOTE thread. I have sent a separate mail to the dev mailing list with the same request.

        Show
        Rahul Ravindran added a comment - Mike Percy , I just joined the dev list and don't seem to be able to respond to an older thread. Would be thankful if you could bring this up in the 1.3 VOTE thread. I have sent a separate mail to the dev mailing list with the same request.
        Hide
        Mike Percy added a comment -

        Moving fixVersion to v1.3.0 since Brock backported this to the 1.3 release branch.

        Show
        Mike Percy added a comment - Moving fixVersion to v1.3.0 since Brock backported this to the 1.3 release branch.
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #333 (See https://builds.apache.org/job/flume-trunk/333/)
        FLUME-1713. Netcat source should allow for not returning "OK" upon receipt of each message. (Revision e257e3db054d8a8282bfb14187f2dadf8e3c13e4)

        Result = UNSTABLE
        mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e257e3db054d8a8282bfb14187f2dadf8e3c13e4
        Files :

        • flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java
        • flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java
        • flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java
        • flume-ng-doc/sphinx/FlumeUserGuide.rst
        Show
        Hudson added a comment - Integrated in flume-trunk #333 (See https://builds.apache.org/job/flume-trunk/333/ ) FLUME-1713 . Netcat source should allow for not returning "OK" upon receipt of each message. (Revision e257e3db054d8a8282bfb14187f2dadf8e3c13e4) Result = UNSTABLE mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e257e3db054d8a8282bfb14187f2dadf8e3c13e4 Files : flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java flume-ng-doc/sphinx/FlumeUserGuide.rst

          People

          • Assignee:
            Rahul Ravindran
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development