Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1686

Exclude target directories & Eclipse files from rat checks

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.4.0
    • Component/s: Build
    • Labels:
      None

      Description

      Rat checks should exclude target directories created by the maven build (similar to other projects like hbase)

      1. FLUME-1686.patch
        0.4 kB
        Roshan Naik
      2. FLUME-1686-2.patch
        0.6 kB
        Edward Sargisson

        Issue Links

          Activity

          Hide
          roshan_naik Roshan Naik added a comment -

          Just a one liner change.. adding */target/* to Rat exclusion list in pom.xml

          Show
          roshan_naik Roshan Naik added a comment - Just a one liner change.. adding * /target/ * to Rat exclusion list in pom.xml
          Hide
          mpercy Mike Percy added a comment -

          Wondering if we need to check the docs using rat. I think the docs currently pass the test and I believe they end up in target/, but we do shenanigans to move the files around so I don't know where they live during the rat check. However I'm not sure they are required to pass the test because they are generated.

          Show
          mpercy Mike Percy added a comment - Wondering if we need to check the docs using rat. I think the docs currently pass the test and I believe they end up in target/, but we do shenanigans to move the files around so I don't know where they live during the rat check. However I'm not sure they are required to pass the test because they are generated.
          Hide
          roshan_naik Roshan Naik added a comment -

          Mike.. could you take a look and commit it if there are no issues.

          Show
          roshan_naik Roshan Naik added a comment - Mike.. could you take a look and commit it if there are no issues.
          Hide
          roshan_naik Roshan Naik added a comment -

          Mike .. could you ?

          Show
          roshan_naik Roshan Naik added a comment - Mike .. could you ?
          Hide
          ejsarge Edward Sargisson added a comment -

          This issue affects developers wishing to build locally. Using the project from Eclipse produces extra files which Rat fails on. The embedded elasticsearch used in the unit tests also produces files which should be ignored.

          I have attached a patch, FLUME-1686-2.patch, which extends the above patch to cover these situations.

          Show
          ejsarge Edward Sargisson added a comment - This issue affects developers wishing to build locally. Using the project from Eclipse produces extra files which Rat fails on. The embedded elasticsearch used in the unit tests also produces files which should be ignored. I have attached a patch, FLUME-1686 -2.patch, which extends the above patch to cover these situations.
          Hide
          mpercy Mike Percy added a comment -

          +1. But I am leaving out the last line (data/**) since that is not checked into the Flume tree

          Show
          mpercy Mike Percy added a comment - +1. But I am leaving out the last line (data/**) since that is not checked into the Flume tree
          Hide
          mpercy Mike Percy added a comment -

          Pushed to trunk & flume-1.4 branches. Thanks Roshan & Edward!

          Show
          mpercy Mike Percy added a comment - Pushed to trunk & flume-1.4 branches. Thanks Roshan & Edward!
          Hide
          hudson Hudson added a comment -

          Integrated in flume-trunk #377 (See https://builds.apache.org/job/flume-trunk/377/)
          FLUME-1686. Exclude target directories & Eclipse files from rat checks. (Revision 3b29a3c07cbd6e5ac70cc55e506ffaf7ceecfbe2)

          Result = FAILURE
          mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=3b29a3c07cbd6e5ac70cc55e506ffaf7ceecfbe2
          Files :

          • pom.xml
          Show
          hudson Hudson added a comment - Integrated in flume-trunk #377 (See https://builds.apache.org/job/flume-trunk/377/ ) FLUME-1686 . Exclude target directories & Eclipse files from rat checks. (Revision 3b29a3c07cbd6e5ac70cc55e506ffaf7ceecfbe2) Result = FAILURE mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=3b29a3c07cbd6e5ac70cc55e506ffaf7ceecfbe2 Files : pom.xml

            People

            • Assignee:
              roshan_naik Roshan Naik
              Reporter:
              roshan_naik Roshan Naik
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development