Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1679

Add dependency on Guava to flume-ng-elasticsearch-sink POM

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4.0
        • Fix Version/s: 1.5.0
        • Component/s: Sinks+Sources
        • Labels:
          None

          Description

          The Elasticsearch sink depends on Guava but this is not reflected in the POM.

          1. Text File
            FLUME-1679.patch
            0.5 kB
            Andrew Purtell
          2. Text File
            FLUME-1679-1.patch
            0.5 kB
            Ashish Paliwal

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            apurtell Andrew Purtell added a comment -

            Head of 1.4 branch won't build without attached patch.

            Show
            apurtell Andrew Purtell added a comment - Head of 1.4 branch won't build without attached patch.
            Hide
            Permalink
            paliwalashish Ashish Paliwal added a comment -

            Andrew Purtell] Guava dep is coming as a transitive dependency from flume-ng-core. As of now the build works fine without applying the patch. Can you please confirm if this is still an issue.

            Show
            paliwalashish Ashish Paliwal added a comment - Andrew Purtell ] Guava dep is coming as a transitive dependency from flume-ng-core. As of now the build works fine without applying the patch. Can you please confirm if this is still an issue.
            Hide
            Permalink
            paliwalashish Ashish Paliwal added a comment -

            Hari ShreedharanMike Percy Can you please have a look at this JIRA. IMHO we can mark it as resolved. Please see my comments above.

            Show
            paliwalashish Ashish Paliwal added a comment - Hari Shreedharan Mike Percy Can you please have a look at this JIRA. IMHO we can mark it as resolved. Please see my comments above.
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            If the specific module requires it, it should be explicitly added (since the core module may, even though unlikely, get rid of it at some point, causing the build to fail). I will review this soon.

            Show
            hshreedharan Hari Shreedharan added a comment - If the specific module requires it, it should be explicitly added (since the core module may, even though unlikely, get rid of it at some point, causing the build to fail). I will review this soon.
            Hide
            Permalink
            paliwalashish Ashish Paliwal added a comment -

            Got it! I had a different understanding, this makes sense. Thanks!

            Show
            paliwalashish Ashish Paliwal added a comment - Got it! I had a different understanding, this makes sense. Thanks!
            Hide
            Permalink
            paliwalashish Ashish Paliwal added a comment -

            Rebased the patch and updated JIRA as Patch available. Trivial change, skipping review process

            Show
            paliwalashish Ashish Paliwal added a comment - Rebased the patch and updated JIRA as Patch available. Trivial change, skipping review process
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            Assigning to Andrew since he submitted the original patch

            Show
            hshreedharan Hari Shreedharan added a comment - Assigning to Andrew since he submitted the original patch
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            +1. Looks good. Committing.

            Show
            hshreedharan Hari Shreedharan added a comment - +1. Looks good. Committing.
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            Committed, rev: 58f3f6fb18e18fbf67fbd1ae0044c337845eba8d. Thanks Andrew for the patch, and Ashish for rebasing it.

            Show
            hshreedharan Hari Shreedharan added a comment - Committed, rev: 58f3f6fb18e18fbf67fbd1ae0044c337845eba8d. Thanks Andrew for the patch, and Ashish for rebasing it.
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in flume-trunk #527 (See https://builds.apache.org/job/flume-trunk/527/)
            FLUME-1679. Add dependency on Guava to flume-ng-elasticsearch-sink POM (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=58f3f6fb18e18fbf67fbd1ae0044c337845eba8d)

            • flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #527 (See https://builds.apache.org/job/flume-trunk/527/ ) FLUME-1679 . Add dependency on Guava to flume-ng-elasticsearch-sink POM (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=58f3f6fb18e18fbf67fbd1ae0044c337845eba8d ) flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml

              People

              • Assignee:
                apurtell Andrew Purtell
                Reporter:
                apurtell Andrew Purtell
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development