Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: v1.2.0, v1.3.0, v1.4.0
    • Fix Version/s: v1.6.0
    • Component/s: Docs
    • Labels:
      None

      Description

      StressSource is absent at UserGuide, we should fix it

      1. FLUME-1521-1.patch
        2 kB
        Ashish Paliwal
      2. FLUME-1521.patch
        2 kB
        Denny Ye

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Flume-trunk-hbase-98 #55 (See https://builds.apache.org/job/Flume-trunk-hbase-98/55/)
          FLUME-1521. Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959)

          • flume-ng-doc/sphinx/FlumeUserGuide.rst
          Show
          Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #55 (See https://builds.apache.org/job/Flume-trunk-hbase-98/55/ ) FLUME-1521 . Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959 ) flume-ng-doc/sphinx/FlumeUserGuide.rst
          Hide
          Hudson added a comment -

          UNSTABLE: Integrated in flume-trunk #698 (See https://builds.apache.org/job/flume-trunk/698/)
          FLUME-1521. Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959)

          • flume-ng-doc/sphinx/FlumeUserGuide.rst
          Show
          Hudson added a comment - UNSTABLE: Integrated in flume-trunk #698 (See https://builds.apache.org/job/flume-trunk/698/ ) FLUME-1521 . Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959 ) flume-ng-doc/sphinx/FlumeUserGuide.rst
          Hide
          Ashish Paliwal added a comment -

          Done. Raised FLUME-2558 for javadoc issue.

          Show
          Ashish Paliwal added a comment - Done. Raised FLUME-2558 for javadoc issue.
          Hide
          Roshan Naik added a comment -

          Committed.
          Thanks for the patch Ashish!

          Show
          Roshan Naik added a comment - Committed. Thanks for the patch Ashish!
          Hide
          ASF subversion and git services added a comment -

          Commit 0b7568229082767259a165b6e29f418d880dec23 in flume's branch refs/heads/flume-1.6 from Roshan Naik
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=0b75682 ]

          FLUME-1521. Document the StressSource

          (Ashish Paliwal via Roshan Naik)

          Show
          ASF subversion and git services added a comment - Commit 0b7568229082767259a165b6e29f418d880dec23 in flume's branch refs/heads/flume-1.6 from Roshan Naik [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=0b75682 ] FLUME-1521 . Document the StressSource (Ashish Paliwal via Roshan Naik)
          Hide
          ASF subversion and git services added a comment -

          Commit a73b6785332a55eeb82f4a915e09cee305714959 in flume's branch refs/heads/trunk from Roshan Naik
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a73b678 ]

          FLUME-1521. Document the StressSource

          (Ashish Paliwal via Roshan Naik)

          Show
          ASF subversion and git services added a comment - Commit a73b6785332a55eeb82f4a915e09cee305714959 in flume's branch refs/heads/trunk from Roshan Naik [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a73b678 ] FLUME-1521 . Document the StressSource (Ashish Paliwal via Roshan Naik)
          Hide
          Roshan Naik added a comment -

          +1 . This patch looks ok.

          Ashish Paliwal could you capture the the pending javadoc issue in a new jira ?

          Show
          Roshan Naik added a comment - +1 . This patch looks ok. Ashish Paliwal could you capture the the pending javadoc issue in a new jira ?
          Hide
          Ashish Paliwal added a comment -

          Hari Shreedharan can you please review it? minor one, might need rebasing

          Show
          Ashish Paliwal added a comment - Hari Shreedharan can you please review it? minor one, might need rebasing
          Hide
          Ashish Paliwal added a comment -

          Updated the User Guide. We can also update the javadoc, didn't update it as part of the patch so that change context is maintained. Should I raise one more jira or fix it as part of this?

          Show
          Ashish Paliwal added a comment - Updated the User Guide. We can also update the javadoc, didn't update it as part of the patch so that change context is maintained. Should I raise one more jira or fix it as part of this?
          Hide
          Ashish Paliwal added a comment -

          Taking over the JIRA, seems like review comments need to be incorporated

          Show
          Ashish Paliwal added a comment - Taking over the JIRA, seems like review comments need to be incorporated
          Hide
          Mike Percy added a comment -

          Temporarily cancelling patch available status based on review feedback

          Show
          Mike Percy added a comment - Temporarily cancelling patch available status based on review feedback
          Hide
          Mike Percy added a comment -

          Hi Denny,
          Any plans to update this patch based on review feedback?

          Show
          Mike Percy added a comment - Hi Denny, Any plans to update this patch based on review feedback?
          Hide
          Brock Noland added a comment -

          Denny, this looks good overall! Thank you for creating the patch to document this! I have just a few nits below:

          1) batchSize should be documented as well

          2) In regards to the description, how about:

          StressSource is allows for stress testing of Flume. Users can configure the body size of each event
          which will have an empty header. The total number and total successful number of events can be
          configured as well.

          3) In regards to maxTotalEvents and maxSuccessfulEvents, how about:

          maxTotalEvents -1 Maximum number of events that will be pushed to Channel
          maxSuccessfulEvents -1 Maximum number of events successful events that will be pushed to Channel

          Show
          Brock Noland added a comment - Denny, this looks good overall! Thank you for creating the patch to document this! I have just a few nits below: 1) batchSize should be documented as well 2) In regards to the description, how about: StressSource is allows for stress testing of Flume. Users can configure the body size of each event which will have an empty header. The total number and total successful number of events can be configured as well. 3) In regards to maxTotalEvents and maxSuccessfulEvents, how about: maxTotalEvents -1 Maximum number of events that will be pushed to Channel maxSuccessfulEvents -1 Maximum number of events successful events that will be pushed to Channel

            People

            • Assignee:
              Ashish Paliwal
              Reporter:
              Denny Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development