Details
Improvement
Minor
Description
StressSource is absent at UserGuide, we should fix it
Issue Links
- links to
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Hi Denny,
Any plans to update this patch based on review feedback?
Temporarily cancelling patch available status based on review feedback
Taking over the JIRA, seems like review comments need to be incorporated
Updated the User Guide. We can also update the javadoc, didn't update it as part of the patch so that change context is maintained. Should I raise one more jira or fix it as part of this?
Hari Shreedharan can you please review it? minor one, might need rebasing
+1 . This patch looks ok.
Ashish Paliwal could you capture the the pending javadoc issue in a new jira ?
Commit a73b6785332a55eeb82f4a915e09cee305714959 in flume's branch refs/heads/trunk from Roshan Naik
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a73b678 ]
FLUME-1521. Document the StressSource
(Ashish Paliwal via Roshan Naik)
Commit 0b7568229082767259a165b6e29f418d880dec23 in flume's branch refs/heads/flume-1.6 from Roshan Naik
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=0b75682 ]
FLUME-1521. Document the StressSource
(Ashish Paliwal via Roshan Naik)
Committed.
Thanks for the patch Ashish!
Done. Raised FLUME-2558 for javadoc issue.
UNSTABLE: Integrated in flume-trunk #698 (See https://builds.apache.org/job/flume-trunk/698/)
FLUME-1521. Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959)
- flume-ng-doc/sphinx/FlumeUserGuide.rst
SUCCESS: Integrated in Flume-trunk-hbase-98 #55 (See https://builds.apache.org/job/Flume-trunk-hbase-98/55/)
FLUME-1521. Document the StressSource (roshan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a73b6785332a55eeb82f4a915e09cee305714959)
- flume-ng-doc/sphinx/FlumeUserGuide.rst
Denny, this looks good overall! Thank you for creating the patch to document this! I have just a few nits below:
1) batchSize should be documented as well
2) In regards to the description, how about:
StressSource is allows for stress testing of Flume. Users can configure the body size of each event
which will have an empty header. The total number and total successful number of events can be
configured as well.
3) In regards to maxTotalEvents and maxSuccessfulEvents, how about:
maxTotalEvents -1 Maximum number of events that will be pushed to Channel
maxSuccessfulEvents -1 Maximum number of events successful events that will be pushed to Channel