Flume
  1. Flume
  2. FLUME-1501

Flume Scribe Source needs unit tests.

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.4.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    1. FLUME-1501-0.patch
      8 kB
      Ashish Paliwal
    2. FLUME-1501-1.patch
      7 kB
      Ashish Paliwal
    3. FLUME-1501-2.patch
      6 kB
      Ashish Paliwal
    4. FLUME-1501-3.patch
      5 kB
      Ashish Paliwal

      Issue Links

        Activity

        Hide
        Denny Ye added a comment -

        hi Hari, I will post my test cases. Maybe only cover the ScribeSource class. The rest are generated classes.

        Show
        Denny Ye added a comment - hi Hari, I will post my test cases. Maybe only cover the ScribeSource class. The rest are generated classes.
        Hide
        Ashish Paliwal added a comment -

        Taking over this JIRA. Please reassign in case some work has already been done.

        Show
        Ashish Paliwal added a comment - Taking over this JIRA. Please reassign in case some work has already been done.
        Hide
        Ashish Paliwal added a comment -

        Added Test cases for Scribe source

        Show
        Ashish Paliwal added a comment - Added Test cases for Scribe source
        Hide
        Hari Shreedharan added a comment -

        This patch does not seem to apply. Can you regenerate it based on trunk please?

        Show
        Hari Shreedharan added a comment - This patch does not seem to apply. Can you regenerate it based on trunk please?
        Hide
        Ashish Paliwal added a comment -

        yeah, it's an old one. I shall rebase it. Do you need updated review request as well?

        Show
        Ashish Paliwal added a comment - yeah, it's an old one. I shall rebase it. Do you need updated review request as well?
        Hide
        Ashish Paliwal added a comment -

        Trying to find where I kept the patch, shall be done in another 15 min. There are too many patches in local box.

        Show
        Ashish Paliwal added a comment - Trying to find where I kept the patch, shall be done in another 15 min. There are too many patches in local box.
        Hide
        Ashish Paliwal added a comment -

        Rebased the patch against trunk. No changes done to the code. Existing review request stands good.

        Show
        Ashish Paliwal added a comment - Rebased the patch against trunk. No changes done to the code. Existing review request stands good.
        Hide
        Hari Shreedharan added a comment -

        git apply ~/work/patches-commited/FLUME-1501-1.patch
        error: flume-ng-sources/flume-scribe-source/test/java/org/apache/flume/source/scribe/TestScribeSource.java: No such file or directory
        error: flume-ng-sources/flume-scribe-source/test/resources/log4j.properties: No such file or directory

        Looks like this patch is based on a previous commit, which is not upstream.

        Show
        Hari Shreedharan added a comment - git apply ~/work/patches-commited/ FLUME-1501 -1.patch error: flume-ng-sources/flume-scribe-source/test/java/org/apache/flume/source/scribe/TestScribeSource.java: No such file or directory error: flume-ng-sources/flume-scribe-source/test/resources/log4j.properties: No such file or directory Looks like this patch is based on a previous commit, which is not upstream.
        Hide
        Ashish Paliwal added a comment -

        This is a diff problem. If the files are new, we need to add them to git using -N (intend to add), simple add doesn't work. I remember doing this. Let me verify again and push the working stuff.

        Show
        Ashish Paliwal added a comment - This is a diff problem. If the files are new, we need to add them to git using -N (intend to add), simple add doesn't work. I remember doing this. Let me verify again and push the working stuff.
        Hide
        Ashish Paliwal added a comment -

        Can't seem to get it working. Tried tricks, that I used earlier but nothing worked so far.

        The files are new in this patch, and I have tried both git add as well as git add -N options, before generating git diff
        Probably I am missing something here. Suggestions?

        Show
        Ashish Paliwal added a comment - Can't seem to get it working. Tried tricks, that I used earlier but nothing worked so far. The files are new in this patch, and I have tried both git add as well as git add -N options, before generating git diff Probably I am missing something here. Suggestions?
        Hide
        Ashish Paliwal added a comment -

        Rebased patch

        Hari Shreedharan Can you please try this. It will create the files, and then you need to issue git add on these.

        Let me know if it works for you. I suspect might hit the same issue for other patches with new files added.

        Show
        Ashish Paliwal added a comment - Rebased patch Hari Shreedharan Can you please try this. It will create the files, and then you need to issue git add on these. Let me know if it works for you. I suspect might hit the same issue for other patches with new files added.
        Hide
        Hari Shreedharan added a comment -

        Actually you need to just do git diff HEAD (assuming HEAD = head to trunk) and it will automatically show the new files.

        Show
        Hari Shreedharan added a comment - Actually you need to just do git diff HEAD (assuming HEAD = head to trunk) and it will automatically show the new files.
        Hide
        Hari Shreedharan added a comment -

        This should work. I see the required headers in the diff.

        Show
        Hari Shreedharan added a comment - This should work. I see the required headers in the diff.
        Hide
        Ashish Paliwal added a comment -

        Cool ! Thanks. Let me know if it works

        Show
        Ashish Paliwal added a comment - Cool ! Thanks. Let me know if it works
        Hide
        Ashish Paliwal added a comment - - edited

        Hari Shreedharan I have rebased the patch to latest code base, and tested by applying locally.

        Show
        Ashish Paliwal added a comment - - edited Hari Shreedharan I have rebased the patch to latest code base, and tested by applying locally.
        Hide
        Ashish Paliwal added a comment -

        Hari Shreedharan Can you please have a look at the patch

        Show
        Ashish Paliwal added a comment - Hari Shreedharan Can you please have a look at the patch
        Hide
        ASF subversion and git services added a comment -

        Commit d2cb4ba7524b3dacbce9f19a524a56c786eb3e48 in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=d2cb4ba ]

        FLUME-1501. Flume Scribe Source needs unit tests.

        (Ashish Paliwal via Hari)

        Show
        ASF subversion and git services added a comment - Commit d2cb4ba7524b3dacbce9f19a524a56c786eb3e48 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=d2cb4ba ] FLUME-1501 . Flume Scribe Source needs unit tests. (Ashish Paliwal via Hari)
        Hide
        ASF subversion and git services added a comment -

        Commit bd7acb49e13de3a0c8b41e3717f3252f149cb68d in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=bd7acb4 ]

        FLUME-1501. Flume Scribe Source needs unit tests.

        (Ashish Paliwal via Hari)

        Show
        ASF subversion and git services added a comment - Commit bd7acb49e13de3a0c8b41e3717f3252f149cb68d in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=bd7acb4 ] FLUME-1501 . Flume Scribe Source needs unit tests. (Ashish Paliwal via Hari)
        Hide
        Hari Shreedharan added a comment -

        Committed! Thanks Ashish!

        Show
        Hari Shreedharan added a comment - Committed! Thanks Ashish!
        Hide
        Hudson added a comment -

        FAILURE: Integrated in flume-trunk #664 (See https://builds.apache.org/job/flume-trunk/664/)
        FLUME-1501. Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48)

        • flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java
        Show
        Hudson added a comment - FAILURE: Integrated in flume-trunk #664 (See https://builds.apache.org/job/flume-trunk/664/ ) FLUME-1501 . Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48 ) flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Flume-trunk-hbase-98 #24 (See https://builds.apache.org/job/Flume-trunk-hbase-98/24/)
        FLUME-1501. Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48)

        • flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java
        Show
        Hudson added a comment - FAILURE: Integrated in Flume-trunk-hbase-98 #24 (See https://builds.apache.org/job/Flume-trunk-hbase-98/24/ ) FLUME-1501 . Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48 ) flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java

          People

          • Assignee:
            Ashish Paliwal
            Reporter:
            Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development