hi Hari, I will post my test cases. Maybe only cover the ScribeSource class. The rest are generated classes.

Taking over this JIRA. Please reassign in case some work has already been done.

Added Test cases for Scribe source

This patch does not seem to apply. Can you regenerate it based on trunk please?

yeah, it's an old one. I shall rebase it. Do you need updated review request as well?

Trying to find where I kept the patch, shall be done in another 15 min. There are too many patches in local box.

Rebased the patch against trunk. No changes done to the code. Existing review request stands good.

git apply ~/work/patches-commited/FLUME-1501-1.patch
error: flume-ng-sources/flume-scribe-source/test/java/org/apache/flume/source/scribe/TestScribeSource.java: No such file or directory
error: flume-ng-sources/flume-scribe-source/test/resources/log4j.properties: No such file or directory

Looks like this patch is based on a previous commit, which is not upstream.

This is a diff problem. If the files are new, we need to add them to git using -N (intend to add), simple add doesn't work. I remember doing this. Let me verify again and push the working stuff.

Can't seem to get it working. Tried tricks, that I used earlier but nothing worked so far.

The files are new in this patch, and I have tried both git add as well as git add -N options, before generating git diff
Probably I am missing something here. Suggestions?

Rebased patch

Hari Shreedharan Can you please try this. It will create the files, and then you need to issue git add on these.

Let me know if it works for you. I suspect might hit the same issue for other patches with new files added.

Actually you need to just do git diff HEAD (assuming HEAD = head to trunk) and it will automatically show the new files.

This should work. I see the required headers in the diff.

Cool ! Thanks. Let me know if it works

Hari Shreedharan I have rebased the patch to latest code base, and tested by applying locally.

Hari Shreedharan Can you please have a look at the patch

Commit d2cb4ba7524b3dacbce9f19a524a56c786eb3e48 in flume's branch refs/heads/trunk from Hari Shreedharan
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=d2cb4ba ]

FLUME-1501. Flume Scribe Source needs unit tests.

(Ashish Paliwal via Hari)

Commit bd7acb49e13de3a0c8b41e3717f3252f149cb68d in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=bd7acb4 ]

FLUME-1501. Flume Scribe Source needs unit tests.

(Ashish Paliwal via Hari)

Committed! Thanks Ashish!

FAILURE: Integrated in flume-trunk #664 (See https://builds.apache.org/job/flume-trunk/664/)
FLUME-1501. Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48)

• flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java

FAILURE: Integrated in Flume-trunk-hbase-98 #24 (See https://builds.apache.org/job/Flume-trunk-hbase-98/24/)
FLUME-1501. Flume Scribe Source needs unit tests. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d2cb4ba7524b3dacbce9f19a524a56c786eb3e48)

• flume-ng-sources/flume-scribe-source/src/test/java/org/apache/flume/source/scribe/TestScribeSource.java