Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-9986

Remove unnecessary information from .version.properties file

    XMLWordPrintableJSON

Details

    Description

      To log the revision flink-runtime creates a .version.properties file using the git-commit-id-plugin that is stored within the jar.

      Here's an example:

      git.commit.id.abbrev=1a9b648
      git.commit.user.email=chesnay@apache.org
      git.commit.message.full=Commit for release 1.5.2\n
      git.commit.id=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
      git.commit.message.short=Commit for release 1.5.2
      git.commit.user.name=zentol
      git.build.user.name=zentol
      git.build.user.email=chesnay@apache.org
      git.branch=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
      git.commit.time=25.07.2018 @ 17\:10\:13 GMT
      git.build.time=25.07.2018 @ 20\:47\:15 GMT
      git.remote.origin.url=https\://github.com/zentol/flink.git
      

      most of this information isn't used, as flink-runtime only access git.commit.id.abbrev and git.commit.time.
      The build, remote and branch information should be removed as they are neither relevant, nor consistent, as releases can be created on any branch, under any git alias, against any remote.

      To exclude properties we have to bump the plugin version to 2.1.9.

      Attachments

        Issue Links

          Activity

            People

              chesnay Chesnay Schepler
              chesnay Chesnay Schepler
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: